Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"feat: add support for "add" parameter in angular-cli-ghpages" #188

Merged

Conversation

isalcedo
Copy link
Contributor

@isalcedo isalcedo commented May 24, 2024

I just added support for the add option in the gh-pages library: https://www.npmjs.com/package/gh-pages#optionsadd

Also, some small fixes to the Readme files.

@JohannesHoppe
Copy link
Member

Looks very great to me, I will test this very soon. 🙂👍

@isalcedo
Copy link
Contributor Author

Looks very great to me, I will test this very soon. 🙂👍

Thank you. Let me know if you need any changes.

@fmalcher
Copy link
Member

We had this topic a while back and closed it. Just for information: #146

@isalcedo
Copy link
Contributor Author

Oh, I didn't know. We need this feature, and instead of building our own solution, I thought it would be great if I collaborate with this project. In any case, I will follow the maintainers lead.

@JohannesHoppe
Copy link
Member

JohannesHoppe commented May 24, 2024

@fmalcher This is indeed a new feature, add would only add, and never remove existing files.

@fmalcher
Copy link
Member

I know, I also think it could be useful. Just wanted to remind us that we discussed this a while ago and had reasons why we didn't include "add" in the end. I just don't remember why 😅
So, let's do it!

@JohannesHoppe JohannesHoppe merged commit accfd97 into angular-schule:main May 27, 2024
@JohannesHoppe
Copy link
Member

@isalcedo Many thanks for your contribution! 😺

https://github.com/angular-schule/angular-cli-ghpages/releases/tag/v2.0.0

@isalcedo
Copy link
Contributor Author

Was a pleasure. Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants