Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support more Tokens (GITHUB_TOKEN, ACTIONS_DEPLOY_KEY) #88

Closed
2 of 3 tasks
JohannesHoppe opened this issue Jan 3, 2020 · 2 comments
Closed
2 of 3 tasks

Support more Tokens (GITHUB_TOKEN, ACTIONS_DEPLOY_KEY) #88

JohannesHoppe opened this issue Jan 3, 2020 · 2 comments
Labels
feature this issue requests a new feature

Comments

@JohannesHoppe
Copy link
Member

JohannesHoppe commented Jan 3, 2020 •
edited
Loading

Related discussions:

We want to support

  • PERSONAL_TOKEN (known as GH_TOKEN for angular-cli-ghpages)
  • GITHUB_TOKEN
  • ACTIONS_DEPLOY_KEY

TODO:
Copy logic from https://github.com/peaceiris/actions-gh-pages/blob/0252bbee4ddab91da948416bd5d300a7baf47216/entrypoint.sh

FYI
@shhdharmen @EdricChan03
@JohannesHoppe JohannesHoppe added the feature this issue requests a new feature label Jan 3, 2020
JohannesHoppe added a commit that referenced this issue Jan 5, 2020
@JohannesHoppe
chore: support for PERSONAL_TOKEN & GITHUB_TOKEN env vars
1066240 
see #88
FYI @EdricChan03
JohannesHoppe added a commit that referenced this issue Jan 5, 2020
@JohannesHoppe
docs: tokens and repo discovery
42747af 
documents c5f7b36
documents 1066240

see #88
@JohannesHoppe
Copy link
Member Author

I think we do not need ACTIONS_DEPLOY_KEY here. It requires Git over SSH, while GitHub encourages the usage of Git over HTTPS. I also think that one should simply never, ever upload any private keys. Period! 😎

@JohannesHoppe
Copy link
Member Author

More tokens are supported in v0.6.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature this issue requests a new feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JohannesHoppe