Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Angular v12 #131

Closed
EdricChan03 opened this issue May 13, 2021 · 9 comments · Fixed by #132
Closed

Support Angular v12 #131

EdricChan03 opened this issue May 13, 2021 · 9 comments · Fixed by #132

Comments

@EdricChan03
Copy link
Contributor

See https://blog.angular.io/angular-v12-is-now-available-32ed51fbfd49 for more info

@JohannesHoppe
Copy link
Member

JohannesHoppe commented May 13, 2021

I will make a new version soonish. But there should be no breaking changes for us. --force should do the trick until then.

@litwin90
Copy link

litwin90 commented May 19, 2021

Hello everyone, when I try to add schematic to new cli (by running ng add angular-cli-ghpages) I get the next warning:
"angular-cli-ghpages-ng-add-schematic" schema is using the keyword "id" which its support is deprecated. Use "$id" for schema ID.

Then when I try to deploy (by running ng deploy --base-href=//) I get a warning and an error:
warning:
"Schema" schema is using the keyword "id" which its support is deprecated. Use "$id" for schema ID.
error:
❌ An error occurred when trying to deploy:
Cannot read property 'Workspace' of undefined

And there is no additional information with --no-silent flag.

Angular CLI: 12.0.0
Node: 14.15.0
Package Manager: npm 6.14.8
OS: win32 x64

I haven't found any information that anybody faced the same issue, so I could suggest that it is a problem with migration to new Angular Cli

@JohannesHoppe
Copy link
Member

@dianjuar have you ever seen this?! o_O

@dianjuar
Copy link
Contributor

dianjuar commented May 20, 2021

@dianjuar have you ever seen this?! o_O

@JohannesHoppe
I haven't taken the time to test V12 but I'm getting the same warning

image

Commands used
ng add ngx-deploy-npm
ng deploy angular-lib


The deployment seems to be right though
image

@dianjuar
Copy link
Contributor

dianjuar commented May 21, 2021

@JohannesHoppe I got it.
You can see what needs to be changed here -> bikecoders/ngx-deploy-npm#63

I'm not merging it because I need to perform some tests related to the builder itself (deprecation of view engine and some Nx concerns). Remember that it's related to libraries.

I think those are all the changes that you need to support V12.
Tell me how it goes 👍

@dianjuar
Copy link
Contributor

@JohannesHoppe
Copy link
Member

Great work. 👍
I have a computer-free weekend right now. But next week I'll apply your changes immediately. 😃

@JohannesHoppe
Copy link
Member

JohannesHoppe commented May 22, 2021

@dianjuar Did you also found the time to check if this change causes problems with older Angular versions?

@dianjuar
Copy link
Contributor

dianjuar commented May 22, 2021

@dianjuar Did you also found the time to check if this change causes problems with older Angular versions?

All good on Angular 12, 11, 10 and 9 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants