Conversation
rainerhahnekamp
left a comment
rainerhahnekamp
left a comment
There was a problem hiding this comment.
Good work @robmanganelly. I've left some comments.
| @@ -1,14 +1,16 @@ | |||
| import { getState, patchState, signalStore, withState } from '@ngrx/signals'; | |||
| import { withStorageSync } from './with-storage-sync'; | |||
| import { withBigIntRehydration, withBigIntReplacement, withStorageSync } from './with-storage-sync'; | |||
There was a problem hiding this comment.
Would it be possible to rename withBigIntRehydration and withBigIntReplacement to serialize and deserialize. I think bigint will not be the last type where we require custom code.
| interface StateObject { | ||
| foo: string; | ||
| age: number; | ||
| big: bigint; |
There was a problem hiding this comment.
Would it be possible, that we leave the tests as they are and just create a separate test which checks the de/serialization for bigint?
There was a problem hiding this comment.
I don't think that the package-lock.json should be changed, right?
| * Function used to parse the state coming from storage. | ||
| * | ||
| * `JSON.parse()` by default | ||
| * ~~`JSON.parse()` by default~~ |
There was a problem hiding this comment.
Yes, you can replace that with parse and stringify (below).
|
Sorry for the late reply. Yes. I will take care of it. Thanks for the
comments.
|
|
@robmanganelly if you don't have the time, no worries. We'll merge and I can do the changes myself. Just let me know, cheers! |
|
Honestly, I don't want to pass the workload onto you guys. I'm really happy
to contribute to this project, even if my contributions are minuscule, but
I currently don't have the bandwidth, sadly, for which I apologize.
I can reach out once I'm done with my current tasks, and if changes are
still needed, I'll be more than happy to handle them myself.
Otherwise, please proceed as you see fit.
|
2 participants
Content of this PR:
Considerations.