Refactor into Rust #404
Draft
Refactor into Rust #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excited! |
twizmwazin
force-pushed
the
feat/rust
branch
7 times, most recently
from
5c8ff18
to
7036249
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an idea I want to experiment with. Basically the idea is that for each class in claripy, make a native class that becomes its base class. Then, one-by-one translate member variables and methods into the base class until the python class is empty. At each step of the way, keep the whole thing integrated and working (hence this PR, I want to test angr in conjunction with my changes). There's going to probably be little or negative performance gains in the early stages of this, but when large sections (ie, the frontend) are fully translated, that's when a speedup might be noticeable.
When converting, I'm not going to try to aggressively narrow the types on the rust side. Many structs will likely have exclusively PyObjects as their member types. Later we can narrow the allowed types.