Avoid creating of several long lists in ROP.__init__ #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`ROP.__init__` currently takes a while (several minutes) on large binaries, mostly due to how optimization attempts generate several long lists for size measurements of `addresses_to_check()`. I've added a function that behaves similarly to `addresses_to_check()` but instead of creating the list and then counting it the function increments
|
This optimization makes sense to me. |
|
Yeah, it looks good to me too. |
|
I agree. Thanks for the optimization! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ROP.__init__currently takes a while (several minutes) on large binaries, mostly due to how optimization attempts generate several long lists for size measurements ofaddresses_to_check().I've added a function that behaves similarly to
addresses_to_check()but avoids creating the list.P.S.
I didn't test this final PR so it could be buggy, but I'll definitely run some tests if the rationale behind it is accepted by maintainers.