Skip to content

Commit

Permalink
cifs: fix noisy message on copy_file_range
Browse files Browse the repository at this point in the history
commit ae4ccca upstream.

There are common cases where copy_file_range can noisily
log "source and target of copy not on same server"
e.g. the mv command across mounts to two different server's shares.
Change this to informational rather than logging as an error.

A followon patch will add dynamic trace points e.g. for
cifs_file_copychunk_range

Cc: [email protected]
Reviewed-by: Shyam Prasad N <[email protected]>
Signed-off-by: Steve French <[email protected]>
Signed-off-by: Greg Kroah-Hartman <[email protected]>
  • Loading branch information
Steve French authored and gregkh committed Jul 25, 2024
1 parent 05ffaf4 commit c15682e
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion fs/smb/client/cifsfs.c
Original file line number Diff line number Diff line change
Expand Up @@ -1404,7 +1404,7 @@ ssize_t cifs_file_copychunk_range(unsigned int xid,
target_tcon = tlink_tcon(smb_file_target->tlink);

if (src_tcon->ses != target_tcon->ses) {
cifs_dbg(VFS, "source and target of copy not on same server\n");
cifs_dbg(FYI, "source and target of copy not on same server\n");
goto out;
}

Expand Down

0 comments on commit c15682e

Please sign in to comment.