Adding code base to support .jshintignore for JSHint linter. #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@orlandoibm it seems that it's a cool feature! But is it possible to do a PR for https://github.com/angelozerr/tern-jshint project and add a test please with your new feature. Thanks! |
|
Hi @angelozerr. I am sorry I did not have time to move my fix to the other repo. I saw you already implemented it, so hopefully this helped you somehow. Regards :) |
midzelis
pushed a commit
to midzelis/tern.java
that referenced
this pull request
Jan 13, 2016
midzelis
pushed a commit
to midzelis/tern.java
that referenced
this pull request
Jan 13, 2016
midzelis
pushed a commit
to midzelis/tern.java
that referenced
this pull request
Jan 13, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Honour .jshintignore when that file exists in the project being validated.
This is highly based on the work originally discussed and advanced here: #265
I noticed that under some scenarios, a few tweaks are necessary to inform JSHint about the correct ignore paths, so most of the work is about handling those special cases (extensive code documentation).