Starting the LSP server locally inside the JVM (second take) #7
Conversation
…irst place, so no licensing worries)
…ally amateurish, but that's how I managed with it so far.
…e process. It still uses server/freemarker-languageserver-all.jar, proving that later this will be able to link to a runtime chosen freemarker.jar as well (that's why it creates its own ClassLoader and uses reflection to invoke the launcher). Note that the committed freemarker-languageserver-all.jar has the new launcher class, but the other classes are from 1492c645aa79ec9b9c610ab619657edccae0fe4a, as their current version crashes with NPE.
ddekany
changed the title
| * http://www.eclipse.org/legal/epl-v10.html | ||
| * | ||
| * Contributors: | ||
| * Angelo Zerr <[email protected]> - initial API and implementation |
| * http://www.eclipse.org/legal/epl-v10.html | ||
| * | ||
| * Contributors: | ||
| * Angelo Zerr <[email protected]> - initial API and implementation |
| @@ -1,5 +1,5 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
| <?pde version="3.8"?><target name="bluesky" sequenceNumber="7"> | |||
| <?pde version="3.8"?><target name="lsp4-freemarker" sequenceNumber="7"> | |||
Just few comments to change and I will merge it. Please too regenerate the freemarker-server-all-.jar whith last version of source code (NPE should be fixed)
Ok I will see that |
|
@ddekany please update server/freemarker-languageserver.jar too. It have disabled the uses of tolerant parser which must support position update (otherwise you will have NPE when outline will be refreshed). |
…eemarker-languageserver dependency.
|
Thanks @ddekany ! |
|
@ddekany I think your class LocalStreamConnectionProvider should be hosted in lsp4e project. Is there any chance that you create a gerrit patch for lsp4e eclipse project? If you have not time, are you OK I create this gerrit patch? |
|
@angelozerr Honestly, I don't feel confident to offer a POC like this to lsp4e itself... I did nearly 0 research. Anyway, since you already know your way around there, feel free to do the gerrit patch. At least we get some feedback on what did I miss... |
|
Ok thanks for your answer. I have created a bugzilla for lsp4e at https://bugs.eclipse.org/bugs/show_bug.cgi?id=533584 and if lsp4e is interested, I will create a gerrit patch with your work (if you are OK).. |
So this time it uses
server/freemarker-languageserver.jar. See the commit message.Note that this PR is after the other pending PR. If you merge that PR first, then this PR is only a single commit.
Also, please see my continued suffering with the development environment setup in the
README.md... would be great if you describe how you do that. Certainly it's not easy for any other newcomer either.