-
Notifications
You must be signed in to change notification settings - Fork 95
1.0 release #134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Sorry for shooting ahead, but since we already had the discussion about 1.0/2.0 I figured there is not much sense in riding the now-deprecated horse much further. You guys agree with the short summary of the 1.0 release? |
I would add that extract text should use a post hook to work automaticly with sass (so you dont need to document anything). Would make order of sassBlock and extract-text block irrelevant |
Good point! |
This looks good to me. I probably wouldn't rebase onto master at this point (too much risk, merge is safer and maintains history) but that's a workflow nit. I'm very 👍 on webpack 2 only. |
True! Updated the list :) |
Update: "Make createConfig.vanilla() the new createConfig()" and "Create a new package with CSS, font, image, ... loaders" are almost done 🎉 Idea: Now that the next LTS release of node is about to be released it might be time to drop support for node < 6.0. Would allow us to drop Babel which is not used consistently. Objections? |
None from me 👍 |
None from me either. Destructuring makes code nicer :) |
Just added a bullet point to "nice to have": This is an idea I had in my mind for some weeks now: The modularity of webpack-blocks is a nice feature, but having to manage a dozen + const { createConfig, env, entryPoint, setOutput, sourceMaps, css, file, babel, devServer } = require('webpack-blocks')
- const { createConfig, env, entryPoint, setOutput, sourceMaps } = require('@webpack-blocks/webpack')
- const { css, file } = require('@webpack-blocks/assets')
- const babel = require('@webpack-blocks/babel6')
- const devServer = require('@webpack-blocks/dev-server')
module.exports = createConfig([ /* ... */ ]) {
"devDependencies": {
+ "webpack-blocks": "^1.0.0",
- "@webpack-blocks/assets": "^1.0.0",
- "@webpack-blocks/babel6": "^1.0.0",
- "@webpack-blocks/dev-server": "^1.0.0",
- "@webpack-blocks/webpack": "^1.0.0",
"webpack": "^2.0.0"
}
} Fewer dependencies in the app, less effort keeping block versions in sync (e.g. Could also be added after the 1.0 release, though. And maybe it should be, since there are still more important things left to do. |
Yes, this may also increase adoption, because simply from a psychological view a single dependency is less scary than a dozend |
This is a nice feature. |
@andywer i suggest to stay babel in the separate package, because not all web devs use it now, for example: typescript devs, electron devs, guys who support only latest versions of chrome/firefox |
It does not matter if it is included or not. Just dont use it. It's a devDependency, so size is not a problem. |
@Wenqer @jvanbruegge You both got valid points, but I'd say the truth lies somewhere in between. We should ship many of the official blocks, because otherwise it won't be very useful and as Jan pointed out, dev dependencies' size does not matter much. On the other hand I would probably not want to include the I suggest including both the |
Ok, yeah I agree, didn't think of the elm block |
A few quick The alpha version of webpack-blocks v1.0 is published! 🎉 Install using Give it a try and report any issues you might encounter. Should be fairly stable for an "alpha", though 😉 Remember that there were breaking changes in the core API. All blocks in this repo have been updated, but third-party blocks or your custom blocks won't work until they are updated as well. |
Maybe tick the assets block and the convenience block in your list :) |
Ohh, of course :) I won't tick the assets preset, since there is the block, but not a preset. Btw, I am not sure if we actually need a preset for that. |
Thanks for the advance warning!
…--
Brandon Konkle
Phone: (720) 239-2573
Twitter:
http://twitter.com/bkonkle http://ecliptic.io/
On Mon, May 08, 2017 at 10:09 AM Andy Wermke < mailto:Andy Wermke <[email protected]> > wrote:
a, pre, code, a:link, body { word-wrap: break-word !important; }
Pinging
https://github.com/bkonkle
,
https://github.com/diegohaz
,
https://github.com/foxbunny
, since they will need to update their blocks. But don't worry, this is like a first official heads-up. A short migration guide will follow (don't worry, it's not hard to update).
—
You are receiving this because you were mentioned.
Reply to this email directly,
#134 (comment)
, or
https://github.com/notifications/unsubscribe-auth/AAB196MV0uL1IftM40-W9_h0D62IDmnyks5r3z4qgaJpZM4Mdq-h
.
|
@andywer I see there are now somewhat non-essential blocks like elm block. What is the official policy regarding contributed blocks? Is it preferred that developers contribute to this repository, or maintain their own? (I'm referring to blocks like vue, riot, or whatever frameworks and technologies people may wish to support.) |
@foxbunny Good question. My current approach is: Open a PR if you think the block is worth being put in the official repository and we will have a look at it and decide if it makes sense to merge 😉 Generally I'd say that most framework-related blocks are probably not supposed to be part of the official repo, except for maybe very popular React or Angular stuff, since they are very dominant. Elm is on the edge of what I'd say should be part of the main repo. But everything is discussable :) I hope that clarifies things at least a little bit! |
Alright, sounds good. |
Is there any progress on this release? |
We should ship it! I don't see any blockers. Better docs would be nice, but shouldn't block the release. |
I think we shouldn’t add more feature before 1.0 release. And improve document detail. |
@andywer Is the 1.0 release ready to be published to NPM? |
I think v1.0 is ready to be published. TypeScript typings would be really nice to have, but who knows how the long that will take (and I have very little time at the moment). @ALL Does anyone see a reason not to release v1.0? |
@andywer I think it's time to finally release v1.0 and to start working on v2.0. |
I'm still up for providing some first typings as soon as we've settled for naming we want to proceed with. |
Left a comment in the typings issue. Yeah, I should just block some time later this week and |
Release v1.0 has been published! 🚀 Read the release notes here. Big thanks to all of you! We did this together 😊 |
@andywer |
@dmitmel Ohh really? That's great! 🙌 |
Awesome 👏 |
Hi everyone! This is gonna be the "1.0 release issue", showing the big picture, in contrast to the many small issues.
Version number change
Since webpack 1.x has officially been deprecated I am now fine with releasing the next webpack-2-only major version as
webpack-blocks 1.0
. So if you find references to a 2.0 release, this will actually be the 1.0 release.Changes
extract-text
andextract-text2
) Remove webpack 1.0 elements for 2.0 branch #127module.rules
syntax module.loaders is now module.rules #111 Port to webpack 2.0 config style #124util
parameter are fine or should be changed API for version 1.0 #125release/1.0
branch, renamerelease/2.0
=>release/1.0
createConfig.vanilla()
the newcreateConfig()
node_modules
exclusion Build fails when set exclude option for CSS Modules and/or PostCSS #133(Not necessarily in that order 😉)
Nice to have
webpack-parts
might be merged into webpack-blocks Merging webpack-parts into webpack-blocks #122@eXon @jvanbruegge @sapegin @aaronjensen
The text was updated successfully, but these errors were encountered: