Skip to content

1.0 release #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
20 of 21 tasks
andywer opened this issue Mar 15, 2017 · 35 comments
Closed
20 of 21 tasks

1.0 release #134

andywer opened this issue Mar 15, 2017 · 35 comments

Comments

@andywer
Copy link
Owner

andywer commented Mar 15, 2017

Hi everyone! This is gonna be the "1.0 release issue", showing the big picture, in contrast to the many small issues.

Version number change

Since webpack 1.x has officially been deprecated I am now fine with releasing the next webpack-2-only major version as webpack-blocks 1.0. So if you find references to a 2.0 release, this will actually be the 1.0 release.

Changes

(Not necessarily in that order 😉)

Nice to have

@eXon @jvanbruegge @sapegin @aaronjensen

@andywer
Copy link
Owner Author

andywer commented Mar 15, 2017

Sorry for shooting ahead, but since we already had the discussion about 1.0/2.0 I figured there is not much sense in riding the now-deprecated horse much further.

You guys agree with the short summary of the 1.0 release?

@jvanbruegge
Copy link
Contributor

I would add that extract text should use a post hook to work automaticly with sass (so you dont need to document anything). Would make order of sassBlock and extract-text block irrelevant

@andywer
Copy link
Owner Author

andywer commented Mar 15, 2017

Good point!

@aaronjensen
Copy link
Contributor

This looks good to me. I probably wouldn't rebase onto master at this point (too much risk, merge is safer and maintains history) but that's a workflow nit. I'm very 👍 on webpack 2 only.

@andywer
Copy link
Owner Author

andywer commented Mar 15, 2017

True! Updated the list :)

@andywer
Copy link
Owner Author

andywer commented Apr 25, 2017

Update: "Make createConfig.vanilla() the new createConfig()" and "Create a new package with CSS, font, image, ... loaders" are almost done 🎉

Idea: Now that the next LTS release of node is about to be released it might be time to drop support for node < 6.0. Would allow us to drop Babel which is not used consistently.

Objections?

@aaronjensen
Copy link
Contributor

None from me 👍

@jvanbruegge
Copy link
Contributor

None from me either. Destructuring makes code nicer :)

@andywer
Copy link
Owner Author

andywer commented May 2, 2017

Just added a bullet point to "nice to have": Create package that wraps all the most common packages, so user does not have to manage dozens of single webpack-blocks packages

This is an idea I had in my mind for some weeks now: The modularity of webpack-blocks is a nice feature, but having to manage a dozen @webpack-blocks/* devDependencies may be cumbersome and does not look too elegant. So a package that exports all the most common blocks might be a nice solution.

+ const { createConfig, env, entryPoint, setOutput, sourceMaps, css, file, babel, devServer } = require('webpack-blocks')
- const { createConfig, env, entryPoint, setOutput, sourceMaps } = require('@webpack-blocks/webpack')
- const { css, file } = require('@webpack-blocks/assets')
- const babel = require('@webpack-blocks/babel6')
- const devServer = require('@webpack-blocks/dev-server')

module.exports = createConfig([ /* ... */ ])
{
  "devDependencies": {
+   "webpack-blocks": "^1.0.0",
-   "@webpack-blocks/assets": "^1.0.0",
-   "@webpack-blocks/babel6": "^1.0.0",
-   "@webpack-blocks/dev-server": "^1.0.0",
-   "@webpack-blocks/webpack": "^1.0.0",
    "webpack": "^2.0.0"
  }
}

Fewer dependencies in the app, less effort keeping block versions in sync (e.g. @webpack-blocks/webpack v1.0 together with @webpack-blocks/dev-server v0.4 will crash), easier to switch to new major versions.

Could also be added after the 1.0 release, though. And maybe it should be, since there are still more important things left to do.

@jvanbruegge
Copy link
Contributor

Yes, this may also increase adoption, because simply from a psychological view a single dependency is less scary than a dozend

@stevenjlho
Copy link

This is a nice feature.

@Wenqer
Copy link

Wenqer commented May 3, 2017

@andywer i suggest to stay babel in the separate package, because not all web devs use it now, for example: typescript devs, electron devs, guys who support only latest versions of chrome/firefox

@jvanbruegge
Copy link
Contributor

It does not matter if it is included or not. Just dont use it. It's a devDependency, so size is not a problem.
I would include all official blocks.

@andywer
Copy link
Owner Author

andywer commented May 3, 2017

@Wenqer @jvanbruegge You both got valid points, but I'd say the truth lies somewhere in between. We should ship many of the official blocks, because otherwise it won't be very useful and as Jan pointed out, dev dependencies' size does not matter much.

On the other hand I would probably not want to include the elm block, for instance, since it will install quite a lot of stuff that the majority of people won't use.

I suggest including both the babel and typescript block. Otherwise it's going to be neither of them (that would be sad) or a decision React vs Angular 😉

@jvanbruegge
Copy link
Contributor

Ok, yeah I agree, didn't think of the elm block

@andywer
Copy link
Owner Author

andywer commented May 8, 2017

A few quick npm publish for me, but a big step forward for webpack-blocks:

The alpha version of webpack-blocks v1.0 is published! 🎉

Install using npm install --save-dev @webpack-blocks/webpack@next ... or using the new convenience package npm install --save-dev webpack-blocks@next.

Give it a try and report any issues you might encounter. Should be fairly stable for an "alpha", though 😉

Remember that there were breaking changes in the core API. All blocks in this repo have been updated, but third-party blocks or your custom blocks won't work until they are updated as well.

@jvanbruegge
Copy link
Contributor

Maybe tick the assets block and the convenience block in your list :)

@andywer
Copy link
Owner Author

andywer commented May 8, 2017

Ohh, of course :)

I won't tick the assets preset, since there is the block, but not a preset. Btw, I am not sure if we actually need a preset for that.

@andywer
Copy link
Owner Author

andywer commented May 8, 2017

Pinging @bkonkle, @diegohaz, @foxbunny, since they will need to update their blocks. But don't worry, this is like a first official heads-up. A short migration guide will follow (don't worry, it's not hard to update).

@bkonkle
Copy link

bkonkle commented May 8, 2017 via email

@foxbunny
Copy link

foxbunny commented May 8, 2017

@andywer I see there are now somewhat non-essential blocks like elm block. What is the official policy regarding contributed blocks? Is it preferred that developers contribute to this repository, or maintain their own? (I'm referring to blocks like vue, riot, or whatever frameworks and technologies people may wish to support.)

@andywer
Copy link
Owner Author

andywer commented May 8, 2017

@foxbunny Good question. My current approach is:

Open a PR if you think the block is worth being put in the official repository and we will have a look at it and decide if it makes sense to merge 😉

Generally I'd say that most framework-related blocks are probably not supposed to be part of the official repo, except for maybe very popular React or Angular stuff, since they are very dominant.

Elm is on the edge of what I'd say should be part of the main repo. But everything is discussable :)

I hope that clarifies things at least a little bit!

@foxbunny
Copy link

foxbunny commented May 8, 2017

Alright, sounds good.

@sapegin sapegin added this to the 1.0.0 milestone Aug 14, 2017
@sapegin sapegin added this to the 1.0.0 milestone Aug 14, 2017
@dmitmel
Copy link
Contributor

dmitmel commented Mar 23, 2018

Is there any progress on this release?

@andywer
Copy link
Owner Author

andywer commented Mar 24, 2018

We should ship it! :shipit:

I don't see any blockers. Better docs would be nice, but shouldn't block the release.

@stevenjlho
Copy link

I think we shouldn’t add more feature before 1.0 release. And improve document detail.

@dmitmel
Copy link
Contributor

dmitmel commented Mar 25, 2018

We should ship it!

@andywer Is the 1.0 release ready to be published to NPM?

@andywer
Copy link
Owner Author

andywer commented Mar 25, 2018

I think v1.0 is ready to be published.

TypeScript typings would be really nice to have, but who knows how the long that will take (and I have very little time at the moment).

@ALL Does anyone see a reason not to release v1.0?

@dmitmel
Copy link
Contributor

dmitmel commented Mar 26, 2018

@andywer I think it's time to finally release v1.0 and to start working on v2.0.

@zcei
Copy link
Collaborator

zcei commented Mar 26, 2018

I'm still up for providing some first typings as soon as we've settled for naming we want to proceed with.
Until then: release the v1.0

@andywer
Copy link
Owner Author

andywer commented Mar 27, 2018

Left a comment in the typings issue.

Yeah, I should just block some time later this week and :shipit: v1.0.
I would schedule it for release on Thursday night (so round about 19:00 UTC).

@andywer
Copy link
Owner Author

andywer commented Mar 29, 2018

Release v1.0 has been published! 🚀

Read the release notes here. Big thanks to all of you! We did this together 😊

@andywer andywer closed this as completed Mar 29, 2018
@dmitmel
Copy link
Contributor

dmitmel commented Mar 29, 2018

@andywer webpack-blocks is the first project on GitHub I've ever contributed to!

@andywer
Copy link
Owner Author

andywer commented Mar 29, 2018

@dmitmel Ohh really? That's great! 🙌

@zcei
Copy link
Collaborator

zcei commented Mar 29, 2018

Awesome 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants