Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draw.io release 26.0.x breaks functionality #127

Closed
FloSch62 opened this issue Jan 7, 2025 · 6 comments
Closed

draw.io release 26.0.x breaks functionality #127

FloSch62 opened this issue Jan 7, 2025 · 6 comments

Comments

@FloSch62
Copy link

FloSch62 commented Jan 7, 2025

Issue Description

After upgrading to draw.io 26.0.4, threshold-based styling (fill colors and stroke colors) no longer works in Grafana Flow Panel. The elements are not getting updated visually, although the data mapping appears correct in the debug console.

Expected Behavior

  • Elements should update their fill colors and stroke colors based on threshold configurations
  • Visual updates should reflect the mapped data values

Current Behavior

  • Elements remain static and do not change colors
  • Debug console shows correct data mapping
  • No visual updates are applied to the diagram elements

Steps to Reproduce

  1. Configure a Flow Panel with threshold-based styling
  2. Use YAML configuration similar to:
anchors:
  thresholds-operstate:
    - color: red
      level: 0
    - color: green
      level: 1
cells:
  port1:
    dataRef: oper-state:ixr1:1/1/1
    fillColor:
      thresholds: *thresholds-operstate
  1. Observe that elements do not update their styling

Environment

draw.io version: 26.0.4
Platform: Desktop and Web versions
Grafana Flow Panel version: latest
Grafana version: latest

Additional Information

Issue is not present in draw.io 25.x and lower versions
Affects both desktop and web versions of draw.io 26.0.x

FloSch62 added a commit to srl-labs/clab-io-draw that referenced this issue Jan 7, 2025
Due to breaking changes in draw.io 26.0.x ([Issue #127](andymchugh/andrewbmchugh-flow-panel#127)), please use draw.io desktop app version 25.x or lower
@andymchugh
Copy link
Owner

Thanks for pointing this out. It looks like the latest draw.io has added additional style information in support of light/dark themes that's overriding the attributes the panel sets. I'll look into it.

@FloSch62
Copy link
Author

FloSch62 commented Jan 7, 2025

Yeah we had a similar problem with this update, with all our drawings.. Thanks for responding so quick 😊

jgraph/drawio#3701 (comment)

Btw, thank you for the plugin, I love it. I automate around it to visualize network topologies
https://github.com/srl-labs/clab-io-draw/blob/main/docs%2Fgrafana.md

@andymchugh
Copy link
Owner

Thanks for the feedback. Your network diagrams look lovely :)

This should be sorted in the just landed version. I'll post here when the build's done and it's published.

@andymchugh
Copy link
Owner

andymchugh commented Jan 14, 2025

This is now published under version 1.17. Unfortunately it missed a couple of document updates so thete is one more patch to come.

@vlacombeTav
Copy link

Thank you for your quick update, I also visualize network topologies with your very useful plugin.

@andymchugh
Copy link
Owner

andymchugh commented Jan 14, 2025

Turns out it didn't miss the documentation updates. It was complete :). I think maybe I looked a bit early and the readme was cached somewhere.

Anyway all done. The read me has stuff added (search for 'draw.io 26') relating to colorMappings examples and the troubleshooting FAQ.

The color drives should all work as before. The colorMappings just gives you the ability to adjust your dynamic colors per theme if you wish.

I'll close this out but just reopen if you still have problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants