Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing min/max to BoardConfigurationColumn #430

Conversation

brenol
Copy link
Contributor

@brenol brenol commented Dec 29, 2021

Description

Please describe what does this Pull Request fix or add?.

Information that is useful here:

Doc pic:
image

  • Type of change: Things like Bugfix, New feature, Code quality improvements, Dependency upgrade, Documentation, ...
    I think it's a new feature, but its also a bug fix, so I labeled the commit as a feature.

  • Breaking change: Yes or no? Backward compatible?
    Backwards compatible

  • Related to an issue: Does this fix or close an issue? Or is related in any kind?
    Did not find any issue

  • Jira Version + Type: Which Jira version and type (on-premise / cloud) you have used?
    Unfortunately I'm not sure.

Example:

Let us know how users can use or test this functionality.

// Example code
id := 26
boardConf, _, err := jira.Board.GetBoardConfiguration(id)
if err != nil { 
    panic(err)
}
// assuming your board has columns...
log.Println(boardConf.ColumnConfig.Columns[0].Min)
log.Println(boardConf.ColumnConfig.Columns[0].Max)

Checklist

board.go Outdated
@@ -117,6 +117,8 @@ type BoardConfigurationColumnConfig struct {
type BoardConfigurationColumn struct {
Name string `json:"name"`
Status []BoardConfigurationColumnStatus `json:"statuses"`
Min int `json:"min"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the omitempty tag to the json config for these new fields as well as tests with omitted min/max

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick reply! Made the changes. 😀

@andygrunwald andygrunwald merged commit f558a51 into andygrunwald:master Dec 30, 2021
@andygrunwald
Copy link
Owner

Thanks @brenol (and @benjivesterby for the review!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants