Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue-418 accept strings as serviceDeskID #419

Conversation

james-cast
Copy link
Contributor

@james-cast james-cast commented Nov 16, 2021

Description

Allow strings to be passed as serviceDeskIDs

Information that is useful here:

  • The What: ^
  • The Why: service desk ids can also be strings, not just ints
  • Type of change: feature
  • Breaking change: No
  • Related to an issue: Issue-418
  • Jira Version + Type: cloud

Example:

go test ./... -v

Checklist

@james-cast james-cast force-pushed the issue-418-accept-strings-as-serviceDeskID branch 2 times, most recently from d02bb73 to bbd57bf Compare November 16, 2021 15:37
see the issue for details on the reason for change

closes issue andygrunwald#418
@benjivesterby benjivesterby merged commit 4ed46d0 into andygrunwald:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants