-
-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding example for Pagination #354
Adding example for Pagination #354
Conversation
@andygrunwald thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be wise to just link to the example in examples/pagination/main.go
instead of copying into the README. That way there isn't duplication but you have the same effect. Thoughts?
@benjivesterby Thanks alot for your help, I've made more changes as you requested. Can you please verify that is satisfy all the requirements. thanks again for looking into this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good except for the vet issue and a typo once those are fixed I'll approve. Also should add a link to the file in the readme as I mentioned in the comment.
Updated accordingly @benjivesterby Thanks for your help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
Description
Adding example of pagination to get all issues for given jql.
code was taken from example given by @eparis at #55
Information that is useful here:
Example:
@andygrunwald please help with below section. I'm unsure.
Checklist