Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Names support on Issue struct #278

Merged
merged 1 commit into from
May 2, 2020

Conversation

bored-engineer
Copy link
Contributor

@bored-engineer bored-engineer commented Apr 29, 2020

PR Description

Adds support for the expand=names field on the Issue struct. Ex:

{
   "id": "1234",
   "names": {
       "customfield_56789": "Sprint",
       "reporter": "Reporter"
    }
}

From JIRA API: Issues -> Get Issue:

Use expand to include additional information about the issues in the response. This parameter accepts a comma-separated list. Expand options include:

  • names Returns the display name of each field.

Checklist

@bored-engineer
Copy link
Contributor Author

I didn't add an error path test as I'm not sure there's a relevant one unless you want me to check for nil when the expand option is not specified.

@andygrunwald andygrunwald merged commit 1fc10e0 into andygrunwald:master May 2, 2020
@andygrunwald
Copy link
Owner

Thanks a lot @bored-engineer

andygrunwald added a commit that referenced this pull request May 12, 2020
* master:
  fix(tests): Fix TestIssueService_PostAttachment unit test
  style: Fix typos
  style: Make code go fmt conform
  chore(test): Remove unit testing log output for success cases (#293)
  feat(project): Add GitHub Actions testing workflow (#289)
  feat(context): Add support for context package
  fix(issue): IssueService.Search() with a not empty JQL triggers 400 bad request (#292)
  feat(IssueService): allow empty JQL (#268)
  style: Fix staticcheck (static analysis) errors for this library (#283)
  feat(project): Add workflow to greet new contributors (#288)
  feat(project): Add cronjob to check for stale issues (#287)
  feat(issues): Add GetEditMeta on issue
  feat: Add Names support on Issue struct (#278)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants