Support of Go versions #290
Milestone
Comments
|
I think it makes sense to support a limited subset. It keeps us moving forward, and saves time when it comes to trying to figure out a "backwards compatible" way to do something. |
andygrunwald
added a commit
that referenced
this issue
May 3, 2020
go-jira follows Go's Release Policy for testing. See https://golang.org/doc/devel/release.html#policy Related #290
andygrunwald
added a commit
that referenced
this issue
May 3, 2020
GitHub actions is a workflow engine. This testing workflow will - keep everything inside GitHub (one platform) - reduce dependency to an external service (TravisCI) - introduce stricter testing (next to unit tests, staticcheck, fmt, vet) * fix(tests): TestIssueService_GetEditMeta_Fail fails on windows due to error message checking We check the error string in TestIssueService_GetEditMeta_Fail. On different operting systems, this error message is different. See - Linux: TestIssueService_GetEditMeta_Fail: metaissue_test.go:456: Error Get "http://127.0.0.1:65328/rest/api/2/issue/PROJ-9001/editmeta": dial tcp 127.0.0.1:65328: connect: connection refused - Windows: Error Get "http://127.0.0.1:50122/rest/api/2/issue/PROJ-9001/editmeta": dial tcp 127.0.0.1:50122: connectex: No connection could be made because the target machine actively refused it. Now we check the error type instead of the error message * chore(tests): Support only the current + the last two versions go-jira follows Go's Release Policy for testing. See https://golang.org/doc/devel/release.html#policy Related #290
|
This issue has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
|
/unstale |
|
@andygrunwald do you have to |
|
@ghostsquad No need to use the /unstale comment. I just used it to make my intentions clear. |
andygrunwald
added
needs triage
andygrunwald
added a commit
that referenced
this issue
Aug 21, 2022
andygrunwald
added a commit
that referenced
this issue
Aug 21, 2022
andygrunwald
added a commit
that referenced
this issue
Aug 21, 2022
* README: Add chapter "State of this library" Related #474 * README: Add chapter "Supported Go versions" Related #290 * Go: Raise supported version to v1.18 Related #290 * Fix "package io/ioutil is deprecated: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (SA1019)" * go fmt
|
Fixed in #491 |
andygrunwald
added a commit
that referenced
this issue
Aug 21, 2022
…documentation" (#492) * README: Add chapter "State of this library" Related #474 * README: Add chapter "Supported Go versions" Related #290 * Go: Raise supported version to v1.18 Related #290 * README: Add chapter "Supported Jira versions" and "Official Jira API documentation" Related: #295 * Fix "package io/ioutil is deprecated: As of Go 1.16, the same functionality is now provided by package io or package os, and those implementations should be preferred in new code. See the specific function documentation for details. (SA1019)" * go fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
Right now go-jira supports go v1.9. - go v1.14
Describe the solution you'd like
Go's Release Policy only support the current version + the last two versions.
Question: Should we follow the same?
Additional context
Right now, I am not aware of any breaking change from the Go language we faced.
However, it would provide clear guidance.
https://github.com/google/go-github is following the policy.
The text was updated successfully, but these errors were encountered: