feat(IssueService): allow empty JQL #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot @kfoxb! |
andygrunwald
added a commit
that referenced
this pull request
May 12, 2020
* master: fix(tests): Fix TestIssueService_PostAttachment unit test style: Fix typos style: Make code go fmt conform chore(test): Remove unit testing log output for success cases (#293) feat(project): Add GitHub Actions testing workflow (#289) feat(context): Add support for context package fix(issue): IssueService.Search() with a not empty JQL triggers 400 bad request (#292) feat(IssueService): allow empty JQL (#268) style: Fix staticcheck (static analysis) errors for this library (#283) feat(project): Add workflow to greet new contributors (#288) feat(project): Add cronjob to check for stale issues (#287) feat(issues): Add GetEditMeta on issue feat: Add Names support on Issue struct (#278)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
This allows the client to make calls with empty JQL specified. My use case is getting all issues in a Jira instance which you typically do by running an empty search. Currently, specifying an empty string makes an invalid URL because the JQL param is always specified. This PR fixes the issue by dynamically building the URL with url.URL and url.Values types according to the options specified.
Note that some tests had to be changed because when you encode url.Values the params get sorted alphabetically.
Checklist