omitempty for AbandonInput.Notify and AbandonInput.NotifyDetails fields #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot, @chizhg. |
|
Using the current sha is fine for me. Thanks for merging it! |
|
Great. Enjoy your day. And thanks again for the contribution. Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set
omitemptyforAbandonInput.NotifyandAbandonInput.NotifyDetailsfields.The reason for this change is that if
NotifyDetailsis not set,notify_detailswill be unmarshalled asnillin the json string, which isn't allowed by the Gerrit server and will result in a400 Bad Requestresponse.