Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for Change API's "Set Commit Message" endpoint #80

Merged
merged 1 commit into from
May 3, 2020
Merged

add support for Change API's "Set Commit Message" endpoint #80

merged 1 commit into from
May 3, 2020

Conversation

srabraham
Copy link
Contributor

Thanks for your excellent Gerrit API client! I wish Google offered something like this.

@codecov-io
Copy link

codecov-io commented May 3, 2020

Codecov Report

Merging #80 into master will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
- Coverage   23.64%   23.56%   -0.08%     
==========================================
  Files          22       22              
  Lines        1844     1850       +6     
==========================================
  Hits          436      436              
- Misses       1342     1348       +6     
  Partials       66       66              
Impacted Files Coverage Δ
changes.go 14.61% <0.00%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f5e365...9976e53. Read the comment docs.

@srabraham
Copy link
Contributor Author

I fixed the lint issue

@andygrunwald
Copy link
Owner

Thanks Sean, for taking the time and the PR!
Would you mind to add a basic unit test here as well?
Then we are ready to go and merge.

@srabraham
Copy link
Contributor Author

Alright, added a couple of tests

@andygrunwald andygrunwald merged commit ed2419a into andygrunwald:master May 3, 2020
@andygrunwald
Copy link
Owner

Thanks @srabraham!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants