Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for digest based authentication #8

Merged
merged 1 commit into from
Jul 16, 2016

Conversation

opalmer
Copy link
Contributor

@opalmer opalmer commented Jul 15, 2016

This should resolve #5

@coveralls
Copy link

coveralls commented Jul 15, 2016

Coverage Status

Coverage decreased (-0.3%) to 8.537% when pulling 1d5fb72 on opalmer:digest_auth into bf7969a on andygrunwald:master.

@opalmer
Copy link
Contributor Author

opalmer commented Jul 15, 2016

@andygrunwald, please have a look. I didn't see any existing tests for auth so I'm not sure if there's more I need to add to the PR but I'm happy to make changes if you have some suggestions. It does like the build is passing except for https://travis-ci.org/andygrunwald/go-gerrit/jobs/145086648 but that test seems to be broken in the current master too.

In any case, thanks for writing go-gerrit!

@andygrunwald
Copy link
Owner

Thank you @opalmer!
I will have a look and test it tomorrow. Then i will provide Feedback

Am Freitag, 15. Juli 2016 schrieb opalmer :

@andygrunwald https://github.com/andygrunwald, please have a look. I
didn't see any existing tests for auth so I'm not sure if there's more I
need to add to the PR but I'm happy to make changes if you have some
suggestions. It does like the build is passing except for
https://travis-ci.org/andygrunwald/go-gerrit/jobs/145086648 but that test
seems to be broken in the current master too.

In any case, thanks for writing go-gerrit!


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#8 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AATiQLJlddyxDNlPQPSNyRwuXzGUN_8Gks5qV90QgaJpZM4JNs2P
.

@andygrunwald andygrunwald merged commit 1d5fb72 into andygrunwald:master Jul 16, 2016
@andygrunwald
Copy link
Owner

It works great, thank you @opalmer!

@opalmer opalmer deleted the digest_auth branch July 17, 2016 15:49
@opalmer opalmer modified the milestone: 0.1.0 Oct 8, 2016
@opalmer opalmer self-assigned this Oct 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement Digest Authentication
3 participants