Implement ListVotes(), DeleteVotes() and add missing tests #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andygrunwald PTAL once this merges I think we can release 0.5.2. |
Codecov Report
@@ Coverage Diff @@
## master #43 +/- ##
==========================================
+ Coverage 19.12% 24.34% +5.21%
==========================================
Files 21 21
Lines 1762 1857 +95
==========================================
+ Hits 337 452 +115
+ Misses 1392 1358 -34
- Partials 33 47 +14
Continue to review full report at Codecov.
|
andygrunwald
approved these changes
Oct 28, 2017
|
LGTM. Good work! |
dmitshur
reviewed
Oct 29, 2017
| @@ -25,6 +25,15 @@ type AddReviewerResult struct { | |||
| Confirm bool `json:"confirm,omitempty"` | |||
| } | |||
|
|
|||
| // DeleteVoteInput entity contains options for the deletion of a vote. | |||
There was a problem hiding this comment.
Minor nit, there are 2 spaces before "entity".
There was a problem hiding this comment.
Thanks! Fixed in 95b11af
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.