-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Static Analysis and Fix Bugs #38
Conversation
We're using MD5 here because of digest auth so there's nothing to fix in this case.
Codecov Report
@@ Coverage Diff @@
## master #38 +/- ##
==========================================
- Coverage 18.06% 17.79% -0.28%
==========================================
Files 21 21
Lines 1738 1742 +4
==========================================
- Hits 314 310 -4
- Misses 1394 1398 +4
- Partials 30 34 +4
Continue to review full report at Codecov.
|
@andygrunwald / @shurcooL please take a look. The only change here that might be worth reverting/working around is testing against Go 1.5. That said if the tests pass on other versions of Go they should pass on 1.5 too (we just can't lint against 1.5). |
This PR adds gometalinter to the project and fixes problems it has found in the process. This PR was created in response to comments made on #37 by @shurcooL to not only make the requested fixes but ensure we don't have these kinds of issues again in the future.
The changes introduced in this PR are documented in the CHANGELOG.