Simplify and optimize RemoveMagicPrefixLine. #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If body has ")]}'\n" prefix, there's no need to use bytes.IndexByte to
find the first '\n' character, it's known to be at index 4 because
bytes.HasPrefix(body, []byte(")]}'\n")) was true.
Since this is called often, it's probably a good idea to factor out
[]byte(")]}'\n") into a package scope variable, instead of potentially
allocating once per RemoveMagicPrefixLine call.
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
=========================================
- Coverage 17.55% 17.45% -0.1%
=========================================
Files 20 20
Lines 1726 1724 -2
=========================================
- Hits 303 301 -2
Misses 1393 1393
Partials 30 30
Continue to review full report at Codecov.
|
opalmer
approved these changes
May 17, 2017
|
Thanks for reviewing. Feel free to merge at your convenience; I can't do it myself. |
|
Thank you @shurcooL :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a suggestion from https://github.com/andygrunwald/go-gerrit/pull/10/files#r116843309.
If body has
")]}'\n"prefix, there's no need to usebytes.IndexByteto find the first'\n'character, it's known to be at index 4 becausebytes.HasPrefix(body, []byte(")]}'\n"))was true.Since this is called often, it's probably a good idea to factor out
[]byte(")]}'\n")into a package scope variable, instead of potentially allocating once perRemoveMagicPrefixLinecall.