Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update PublishChangeEdit: notify param #31

Merged
merged 3 commits into from
Apr 20, 2017

Conversation

banksean
Copy link
Contributor

This fixes a 400 I was getting when calling PublishChangeEdit on chromium-review.googlesource.com. It told me it expected a json body, so this adds one.

This fixes a 400 I was getting when calling PublishChangeEdit on chromium-review.googlesource.com. It told me it expected a json body, so this adds one.
@codecov-io
Copy link

codecov-io commented Apr 19, 2017

Codecov Report

Merging #31 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   17.32%   17.29%   -0.03%     
==========================================
  Files          20       20              
  Lines        1709     1711       +2     
==========================================
  Hits          296      296              
- Misses       1386     1388       +2     
  Partials       27       27
Impacted Files Coverage Δ
changes_edit.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6807790...653e169. Read the comment docs.

@banksean
Copy link
Contributor Author

The coverage reports confuse me. I don't think I changed the lines it's highlighting in this PR.

@andygrunwald
Copy link
Owner

Thanks a lot!

@andygrunwald andygrunwald merged commit 158074a into andygrunwald:master Apr 20, 2017
@opalmer opalmer modified the milestone: 0.3.0 Jun 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants