All DELETE api calls returns error 400 (Bad request)

[priteshpagar93]

Functions ChangesService.DeleteTopic, ChangesService.DeleteDraftChange returns error '400 Bad Requests'.

RCA:

In function NewRequest (inside gerrit.go), we set following headers:
Accept: application/json
Content-Type: application/json

This works for GET, POST api calls.
But as DELETE api calls does not need any content-type, they return 400.

[xobotyi]

Same stuff for Changes.DeleteReviewer

[andygrunwald]

Hey @priteshpagar93 and @xobotyi,

can you provide

• which Gerrit version?
• a piece of example code to reproduce the issue?

Thanks

[xobotyi]

@andygrunwald

• gerrit is 3.2.6
• example is pretty straightforward

g, err := gerrit.NewClient(host, nil)
if err != nil {
	panic(err)
}

g.Authentication.SetBasicAuth(username, password)

if _, _, err := g.Access.ListAccessRights(nil); err != nil {
	panic(err)
}

if _, err := g.Changes.DeleteReviewer("existing change id", "account id that set as reviewer"); err != nil {
	panic(err)
}

[xobotyi]

@andygrunwald made a PR fixing the issue

[andygrunwald]

Thanks both