Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not make all permissions mandatory #80

Closed
Glitchy-Tozier opened this issue Sep 30, 2021 · 8 comments
Closed

Do not make all permissions mandatory #80

Glitchy-Tozier opened this issue Sep 30, 2021 · 8 comments

Comments

@Glitchy-Tozier
Copy link

This screen pops up when i click in the app-icon. This is a good thing, but it shouldn't be mandatory, imo. Some people just don't use tasks, thus making forcing this permission into the user overkill.

Screenshot_20210930-074022_Todo Agenda.jpg

Those two are the problematic permissions:
Screenshot_20210930-074628_Google Play Store.jpg

@yvolk
Copy link
Member

yvolk commented Oct 1, 2021

@Glitchy-Tozier There is no point in the widget if it is not permitted to show anything. As I remember, it's mandatory for our Widget to have permissions for Calendar events OR for Tasks. I.e. at least for something that it could show.
Please check!

And please, switch to English interface and post screenshots in English. Otherwise I'm afraid we will misunderstand each other.

@Glitchy-Tozier
Copy link
Author

The widget already has calendar-permission, and it does show events.
Here's a few screenshots:

20211001_080819.jpg

Screenshot_20211001-080616_Todo Agenda.jpg

Screenshot_20211001-080714_Permission controller.jpg

@yvolk
Copy link
Member

yvolk commented Oct 1, 2021

Please try to explicitly deny permissions for tasks (something like "deny and don't remind me anymore...").
This should work.
?!

@Glitchy-Tozier
Copy link
Author

It didn't. The screen still shows up. (only the popup doesn't show up anymore)

@Glitchy-Tozier
Copy link
Author

I think it'll just be something that is wrong with the code. The page probably always shows up, unless ALL permissions were given. This should be fixed.

@yvolk yvolk changed the title Do not make To-Do Permission mandatory Do not make all permissions mandatory Oct 2, 2021
yvolk added a commit that referenced this issue Jan 3, 2024
@yvolk
Copy link
Member

yvolk commented Jan 3, 2024

Hello @Glitchy-Tozier!
Thank you again for your report, at last I fixed this problem (I hope) by mostly rewriting what the app does to check, to present and to fix permission problems.

When no permissions allowed:
grant-permissions-4-8

When at least one permission is allowed:
grant-permissions-tasks-only-4-8

I posted v.4.8.0 to https://github.com/andstatus/todoagenda/releases/tag/4.8.0-release

@Glitchy-Tozier
Copy link
Author

Sounds great, I'll test it when it arrives in the store 👍🏻

@Glitchy-Tozier
Copy link
Author

Just got the update, it works great! Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants