-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
An option to change the start hour of a day - Handling past-midnight events of the current/previous day #140
Comments
Currently the widget breaks one event that crosses midnight into two parts. The second part starts at midnight and ends at the the time the event ends.
?! For this option to be turned on we need to set it to any value in a range from 1 to say 23 ?! How could we call this option? |
It does, and I don't have a problem with that, though it may be an interesting corner case for shifting the hour of the new day. Multi-day "all day" events (without times) should continue to display under their respective dates, regardless of any offset. Otherwise, for events with times, they should continue to span the necessary dates, but taking into account any offset. Some example ranges and how I'd expect the event to appear in the widget (here assuming a +4 hour offset):
Yes, I think the easiest presentation would be a range of 0 to 23 hours, where 0 retains the current behaviour. Alternatively, it may make more sense to make the range -12 to +12, as setting it to 23 would cause you to be nearly a day out of sync. Here's the UI for a similar option in Anki to choose when it considers it to be the next day for learning: |
@Terrance I see that we described the change behavior differently.
Seeing on Monday "→ 2am" for an event that actually ends on the next day will be confusing... but maybe not for a person, who decided that his day starts at 4am... It's interesting how do feel people who live near the International Date Line https://en.wikipedia.org/wiki/International_Date_Line Interesting calendar tweak. I wonder how many users may actually like it... |
A little more context: I use my calendar as an activity tracker, so I tend to have a large number of relatively short events. If I stay up past midnight, I'd prefer to still see the current "logical" (i.e. from wake to sleep) day's worth of events rather than the "physical" (midnight to midnight) day. 4am is chosen somewhat arbitrarily -- my sleep times vary, but in my case that makes for a good average time where I'll definitely be in bed (7+ hours of sleep is wider than the window of potential sleep hours). I've seen similar options in a few time-based apps (ActivityWatch, Anki, Simple Time Tracker, Sleep as Android to name a few) and it is also nice to have my various apps agree on this.
For comparison, in conversation I'd probably also refer to 2am on Tuesday as "Monday night" still, but I can see not everyone would do so (this may well be a regional thing -- as a British person this makes sense to me, but maybe we're in the minority?) or want this behaviour, hence the request for an option to set this up. |
"Start of next day" in AnkiDroid https://ankidroid.org/docs/manual.html#_reviewing
|
I see many similar usages a "Start hour of a day" option, so I'm choosing this name for the new feature. |
Hello @Terrance ! |
Thanks for implementing this! I've had a play with my usual calendar events and it seems to work exactly as I'd expect. 🙂 |
@Terrance In v.4.11.1. I also improved filtering of past events according to the new meaning of a Start hour of a Day. |
The top of my event list starts with events that end after midnight on the current date, which may include entries I'd consider "yesterday". Events crossing midnight also end up spanning two day sections in the list.
It would be nice if there was an option to offset the time (from midnight) at which a new day is considered to start, and align events in the daily sections accordingly. For example, I'd set mine to +4 hours or 4am as the midpoint of when I'd expect to be asleep -- the "today" section (on say 2024-06-16) would then show events from 2024-06-16 04:00:00 to 2024-06-17 04:00:00, at which point the daily sections would shift up by one.
The text was updated successfully, but these errors were encountered: