This repository was archived by the owner on Aug 2, 2024. It is now read-only.
Fix double toolbar issue in Plant Details page #315
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes include: - Remove the duplicate toolbar in the collapsing layout - Show plant name above watering details - Change text size of plant description We will look into a different layout when we start implementing Material design.
ggfan
approved these changes
Jan 31, 2019
|
Fixes #75 |
andhie
reviewed
Feb 1, 2019
| <TextView | ||
| android:id="@+id/plant_watering" | ||
| android:id="@+id/plant_name" | ||
| style="?android:attr/textAppearanceLarge" |
There was a problem hiding this comment.
Using android:textAppearance would be more suitable than using style as this attr only affects text display
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes include:
We will look into a different layout when we start implementing Material design.