Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add truth for better badging diff output #1085

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

alexvanyo
Copy link
Contributor

Adds truth to the badging task to give a better diff output for the golden and generated badging files.

Error message before:

> Task :app:checkProdReleaseBadging FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:checkProdReleaseBadging'.
> Generated badging is different from golden badging! If this change is intended, run ./gradlew updateProdReleaseBadging

Error message after:

> Task :app:checkProdReleaseBadging FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:checkProdReleaseBadging'.
> Generated badging is different from golden badging! If this change is intended, run ./gradlew updateProdReleaseBadging
  value of:
      readText$default(...)
  diff (-expected +actual):
      @@ -2,6 +2,7 @@
       sdkVersion:'21'
       targetSdkVersion:'34'
       uses-permission: name='android.permission.INTERNET'
      +uses-permission: name='android.permission.RECORD_AUDIO'
       uses-permission: name='android.permission.ACCESS_NETWORK_STATE'
       uses-permission: name='android.permission.POST_NOTIFICATIONS'
       uses-permission: name='android.permission.WAKE_LOCK'
      @@ -111,6 +112,8 @@
       feature-group: label=''
         uses-feature: name='android.hardware.faketouch'
         uses-implied-feature: name='android.hardware.faketouch' reason='default feature for all apps'
      +  uses-feature: name='android.hardware.microphone'
      +  uses-implied-feature: name='android.hardware.microphone' reason='requested android.permission.RECORD_AUDIO permission'
       main
       other-activities
       other-receivers

Change-Id: Id3fab0107bc08adf44ddf07a30e0327e06897d47
@dturner dturner merged commit 74466d6 into main Dec 19, 2023
4 checks passed
@dturner dturner deleted the av/truth-for-badging branch December 19, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants