Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unified Headers: Is strerror_r really __ANDROID_API__ >= 23 ? #339

Closed
gershnik-smartsheet opened this issue Mar 22, 2017 · 5 comments
Closed

Comments

@gershnik-smartsheet
Copy link

Code that uses it and used to compile (arm and x86) for API 19 now breaks with unified headers.
Didn't do any actual investigation whether the function is physically there below 23 but either the old headers have a bug or the new ones do.

@DanAlbert
Copy link
Member

Dup of #324

The fix for this was released in r14b earlier today (it's only in the beta channel of the SDK manager for the moment, but we expect to push it to stable shortly).

@gershnik-smartsheet
Copy link
Author

Oh, the blog post didn't make it clear so I assumed I already have the latest and greatest :)

@DanAlbert
Copy link
Member

Yeah, that was actually the blog post for r14 (not r14b). It just took a long time to get it published. Sorry for the confusion!

It should be perfectly safe to update to r14b even though it's in the beta channel. It's a really small set of changes.

@gershnik-smartsheet
Copy link
Author

No problem at all and will try now. I won't complain about the other issue I see with Boost threads and missing pthread_mutex_timedlock until I check with r14b then :)

@enh
Copy link
Contributor

enh commented Mar 22, 2017

(neither of those are fixed in r14b. the fixes went into bionic yesterday, but aren't even in a nightly NDK yet.)

1951FDG added a commit to 1951FDG/openpyn-nordvpn-juiceSSH that referenced this issue Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants