__NDK_FPABI__ is not empty for -mfloat-abi=softfp in r12 #142
Comments
|
is that causing you problems? we haven't gone back and cleaned up the old header files. r13 should have the unified headers which won't contain any of this (since it was never in the platform at all). |
|
Yes, this is causing some problems, I came with an ugly workaround https://codereview.qt-project.org/#/c/160450/ but a proper fix from NDK will be nicer. What do you mean by unified headers in r13? Please don't tell me that you are going to break the current NDK layout :) . |
|
see issue #120 for more on unified headers. |
Should be reverted when android/ndk#142 is fixed. Change-Id: Ie68807062247bee4969bc9aa00b0221c8147fed7 Reviewed-by: Eskil Abrahamsen Blomfeldt <[email protected]>
|
Is this issue fixed in r13 beta1 ? |
|
No, but a change is in for beta 2. https://android-review.googlesource.com/#/c/248156/ Though, I just grepped in the sources to check, and it looks like I missed some. I'll get those now. |
Ugh. We had redefinitions of all the __builtin_* math functions in here. Test: ./checkbuild.py Bug: android/ndk#142 Change-Id: Iec187c3a542e2dc9b3d628c2a9aa3fb45d7986ef
|
I can confirm that beta 2 fixed the problem. |
As described in #32
__NDK_FPABI__is still defined as__attribute__((pcs("aapcs")))for-mfloat-abi=softfpThe text was updated successfully, but these errors were encountered: