Skip to content

Conversation

@JolandaVerhoef
Copy link
Collaborator

This commit replaces the Material Icons dependency with local drawable resources for all icons used in the Reply sample. This involves:

  • Adding new vector drawable XML files for each icon.
  • Updating composable functions to use painterResource for loading these local drawables instead of relying on the Icons object from the material-icons-extended library.
  • Removing the material-icons-extended dependency from the app's build.gradle.kts file.
  • Adjusting the ReplyTopLevelDestination data class to accept Any for icon resources to accommodate painter resources.

Did a visual check before/after to validate the icons are okay.

This commit replaces the Material Icons dependency with local drawable resources for all icons used in the Reply sample.
This involves:
- Adding new vector drawable XML files for each icon.
- Updating composable functions to use painterResource for loading these local drawables instead of relying on the Icons object from the material-icons-extended library.
- Removing the material-icons-extended dependency from the app's build.gradle.kts file.
- Adjusting the ReplyTopLevelDestination data class to accept `Any` for icon resources to accommodate painter resources.
@JolandaVerhoef JolandaVerhoef requested a review from a team as a code owner July 3, 2025 15:48
@JolandaVerhoef JolandaVerhoef requested review from florina-muntenescu and riggaroo and removed request for florina-muntenescu July 3, 2025 15:48
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @JolandaVerhoef, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the icon management within the Reply sample application. The primary goal was to eliminate the external material-icons-extended dependency by replacing all its usages with locally defined vector drawable resources. This change involves adding new XML drawable files, updating all UI components to reference these local resources, and adjusting the navigation data structure to support the new icon type. The overall impact is a more self-contained and potentially smaller application bundle.

Highlights

  • Dependency Reduction: The material-icons-extended library dependency has been completely removed from the project, streamlining the build and reducing external library reliance.
  • Icon Migration: All instances where Material Icons were used in composable functions have been updated to load icons from local vector drawable resources using painterResource.
  • Resource Management: A comprehensive set of new vector drawable XML files has been added to the res/drawable directory, providing self-contained icon assets for the application.
  • Data Model Adaptation: The ReplyTopLevelDestination data class was modified to accept integer resource IDs for icons, accommodating the switch from ImageVector objects to local drawable references.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the Material Icons dependency with local drawable resources. The drawables have a hardcoded fill color, which prevents them from being tinted by the app's theme. Also, the string resources are incorrect for navigation item labels.

@JolandaVerhoef JolandaVerhoef changed the title Update icons and remove material icons dependency [Reply] Update icons and remove material icons dependency Jul 4, 2025
@JolandaVerhoef JolandaVerhoef merged commit fdcc4d8 into main Jul 4, 2025
5 checks passed
@JolandaVerhoef JolandaVerhoef deleted the jv/reply-new-icons branch July 4, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants