- 
                Notifications
    
You must be signed in to change notification settings  - Fork 5.3k
 
[Jetnews] Update icons and remove material icons dependency #1587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This commit replaces the Material Icons dependency with local drawable resources for all icons used in the JetNews sample.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @JolandaVerhoef, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request significantly refactors how icons are handled within the JetNews sample application. The primary goal is to eliminate the reliance on the Material Icons dependency by replacing all icon usages with custom, locally defined vector drawable resources. This change streamlines the project's dependencies and embeds the icon assets directly within the application.
Highlights
- Dependency Removal: The 
androidx.compose.material.iconsExtendeddependency has been removed from thebuild.gradle.ktsfile, reducing the project's external dependencies. - Icon Source Migration: All instances where Material Icons were used (e.g., 
Icons.Filled.Home,Icons.Filled.Search) have been updated to use local drawable resources (e.g.,painterResource(R.drawable.ic_home),painterResource(R.drawable.ic_search)). - New Local Icon Assets: A comprehensive set of vector drawable XML files has been added to the 
res/drawabledirectory, providing local assets for all previously used Material Icons. 
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description | 
|---|---|---|
| Code Review | /gemini review | 
Performs a code review for the current pull request in its current state. | 
| Pull Request Summary | /gemini summary | 
Provides a summary of the current pull request in its current state. | 
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. | 
| Help | /gemini help | 
Displays a list of available commands. | 
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
- 
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request replaces the Material Icons dependency with local drawable resources, reducing the application's size and external dependencies. The refactoring has been applied consistently throughout the codebase.
        
          
                JetNews/app/src/main/java/com/example/jetnews/ui/article/ArticleScreen.kt
              
                Outdated
          
            Show resolved
            Hide resolved
        
      …leScreen.kt Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
The `android:tint` attribute was removed from several vector drawables in the JetNews sample app, given the tint is set in Compose world.
This commit replaces the Material Icons dependency with local drawable resources for all icons used in the JetNews sample.