Skip to content

Conversation

@JolandaVerhoef
Copy link
Collaborator

This commit replaces the Material Icons dependency with local drawable resources for all icons used in the JetNews sample.

This commit replaces the Material Icons dependency with local drawable resources for all icons used in the JetNews sample.
@JolandaVerhoef JolandaVerhoef requested a review from a team as a code owner July 3, 2025 14:52
@JolandaVerhoef JolandaVerhoef requested review from bentrengrove and riggaroo and removed request for bentrengrove July 3, 2025 14:52
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @JolandaVerhoef, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors how icons are handled within the JetNews sample application. The primary goal is to eliminate the reliance on the Material Icons dependency by replacing all icon usages with custom, locally defined vector drawable resources. This change streamlines the project's dependencies and embeds the icon assets directly within the application.

Highlights

  • Dependency Removal: The androidx.compose.material.iconsExtended dependency has been removed from the build.gradle.kts file, reducing the project's external dependencies.
  • Icon Source Migration: All instances where Material Icons were used (e.g., Icons.Filled.Home, Icons.Filled.Search) have been updated to use local drawable resources (e.g., painterResource(R.drawable.ic_home), painterResource(R.drawable.ic_search)).
  • New Local Icon Assets: A comprehensive set of vector drawable XML files has been added to the res/drawable directory, providing local assets for all previously used Material Icons.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request replaces the Material Icons dependency with local drawable resources, reducing the application's size and external dependencies. The refactoring has been applied consistently throughout the codebase.

JolandaVerhoef and others added 2 commits July 3, 2025 16:03
…leScreen.kt

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
The `android:tint` attribute was removed from several vector drawables
in the JetNews sample app, given the tint is set in Compose world.
@JolandaVerhoef JolandaVerhoef changed the title Update icons and remove material icons dependency [Jetnews] Update icons and remove material icons dependency Jul 3, 2025
@JolandaVerhoef JolandaVerhoef merged commit b73fc55 into main Jul 4, 2025
5 checks passed
@JolandaVerhoef JolandaVerhoef deleted the jv/jetcaster-new-icons branch July 4, 2025 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants