Skip to content

Update README.md #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025
Merged

Update README.md #1576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Jetcaster/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,9 @@
# Jetcaster sample 🎙️

Jetcaster is a sample podcast app, built with [Jetpack Compose][compose]. The goal of the sample is to
showcase building with Compose across multiple form factors (mobile, TV, and Wear) and full featured architecture.
showcase building with Compose across multiple form factors (mobile, TV, and Wear) and full featured architecture. This sample also showcases Material Expressive elements.

Set your device to dark theme when trying out Jetcaster. This app features a dark theme as the primary theme of the app, since contextually media apps benefit greatly from dark themes. It also shows that contrast and expressive design can still be honored with dark themes.
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The statement 'This app features a dark theme as the primary theme of the app' could be slightly clarified. While the strong recommendation to use dark theme is excellent for guiding users to the intended showcase experience, 'primary theme' might imply that the app always defaults to dark or that its light theme is significantly less supported. However, the theming code (e.g., in mobile/.../Theme.kt) respects the system's current setting via isSystemInDarkTheme().

To enhance clarity and align perfectly with the app's behavior while still emphasizing the dark theme, consider a slight rephrasing. This helps ensure users on light-themed systems understand why dark theme is recommended if the app initially respects their light system theme.

Suggested change
Set your device to dark theme when trying out Jetcaster. This app features a dark theme as the primary theme of the app, since contextually media apps benefit greatly from dark themes. It also shows that contrast and expressive design can still be honored with dark themes.
Set your device to dark theme when trying out Jetcaster. Jetcaster's design is best showcased in its dark theme, which is why we recommend this setting; media apps contextually benefit greatly from dark themes. It also shows that contrast and expressive design can still be honored with dark themes.


To try out this sample app, use the latest stable version
of [Android Studio](https://developer.android.com/studio).
Expand Down