[Jetchat] fix: wrong highlighted item in drawer #1507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magdalena-trivina
changed the title
mlykotom
approved these changes
Nov 19, 2024
Contributor
|
pls check formatting |
…//github.com/magdalena-trivina/compose-samples into jetchat/fix_wrong-highlighted-item-in-drawer
Contributor
Author
|
I've applied the formatting, appreciate if you could check. Thanks. |
Contributor
|
@magdalena-trivina - still failing due to formatting, please make sure to run spotless, you can find the info in the README: To automatically format all samples: Run ./scripts/format.sh To check one sample for errors: Navigate to the sample folder and run ./gradlew --init-script buildscripts/init.gradle.kts spotlessCheck To format one sample: Navigate to the sample folder and run ./gradlew --init-script buildscripts/init.gradle.kts spotlessApply |
Contributor
|
Thank you for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drawer always highlights the first item ("composers"). The highlighted item doesn't changes according to the last selected item. This solves issue #1501
[Before]
Selected item in Drawer (before).webm
[After]
Selected item in Drawer (after).webm