Skip to content

Switch to using local debug.keystore in all samples. #1362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Apr 29, 2024
Merged

Switch to using local debug.keystore in all samples. #1362

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
3f8be4e
Switch to using local debug keystore instead of packaged one.
riggaroo Apr 25, 2024
82feefd
Switch other samples to use local debug keystore
riggaroo Apr 25, 2024
b31aaff
Merge branch 'refs/heads/main' into bugfix/fix-debug-keystores
riggaroo Apr 26, 2024
7fc6f96
Upload new keystore with secret password, default to user.home debug.…
riggaroo Apr 26, 2024
51b0831
Remove debug signing config
riggaroo Apr 26, 2024
1683211
Move env variables to all steps.
riggaroo Apr 26, 2024
10301e2
Merge branch 'main' into bugfix/fix-debug-keystores
riggaroo Apr 26, 2024
33796df
Changed to uppercase for secret retrieval
riggaroo Apr 27, 2024
727a2e5
Add as input for each yaml file.
riggaroo Apr 27, 2024
092268e
Add secrets heading
riggaroo Apr 27, 2024
cd9aab9
add inputs to workflow
riggaroo Apr 27, 2024
ae58d32
add as env variable
riggaroo Apr 27, 2024
0c468f4
Remove duplicate $
riggaroo Apr 27, 2024
66e8f0d
add to test env
riggaroo Apr 27, 2024
b22b5a9
switch to ubuntu for reply
riggaroo Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Crane/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ android {
signingConfigs {
// We use a bundled debug keystore, to allow debug builds from CI to be upgradable
named("debug") {
storeFile = rootProject.file("debug.keystore")
storeFile = File(System.getProperty("user.home"), ".android/debug.keystore")
storePassword = "android"
keyAlias = "androiddebugkey"
keyPassword = "android"
Expand Down
Binary file removed Crane/debug.keystore
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions JetLagged/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ android {
}

signingConfigs {
Copy link
Contributor

@jdkoren jdkoren Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we just remove this block altogether? I think Android Studio already defaults to the local key with these parameters for debug builds.

Copy link
Contributor

@mlykotom mlykotom Apr 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question is if the benchmark buildType allows it, but I assume there's default signingConfig even if it's not defined.

Copy link
Collaborator Author

@riggaroo riggaroo Apr 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark requires release build, and release requires a certificate :-/ Not sure how else to work around this

// We use a bundled debug keystore, to allow debug builds from CI to be upgradable
// Important: change the keystore for a production deployment
named("debug") {
storeFile = rootProject.file("debug.keystore")
storeFile = File(System.getProperty("user.home"), ".android/debug.keystore")
storePassword = "android"
keyAlias = "androiddebugkey"
keyPassword = "android"
Expand Down
Binary file removed JetLagged/debug.keystore
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions JetNews/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ android {
}

signingConfigs {
// We use a bundled debug keystore, to allow debug builds from CI to be upgradable
// Important: change the keystore for a production deployment
named("debug") {
storeFile = rootProject.file("debug.keystore")
storeFile = File(System.getProperty("user.home"), ".android/debug.keystore")
storePassword = "android"
keyAlias = "androiddebugkey"
keyPassword = "android"
Expand Down
Binary file removed JetNews/debug.keystore
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions Jetcaster/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ android {
}

signingConfigs {
// We use a bundled debug keystore, to allow debug builds from CI to be upgradable
// Important: change the keystore for a production deployment
named("debug") {
storeFile = rootProject.file("debug.keystore")
storeFile = File(System.getProperty("user.home"), ".android/debug.keystore")
storePassword = "android"
keyAlias = "androiddebugkey"
keyPassword = "android"
Expand Down
Binary file removed Jetcaster/debug.keystore
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions Jetchat/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ android {
}

signingConfigs {
// We use a bundled debug keystore, to allow debug builds from CI to be upgradable
// Important: change the keystore for a production deployment
named("debug") {
storeFile = rootProject.file("debug.keystore")
storeFile = File(System.getProperty("user.home"), ".android/debug.keystore")
storePassword = "android"
keyAlias = "androiddebugkey"
keyPassword = "android"
Expand Down
Binary file removed Jetchat/debug.keystore
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions Jetsnack/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ android {
}

signingConfigs {
// We use a bundled debug keystore, to allow debug builds from CI to be upgradable
// Important: change the keystore for a production deployment
named("debug") {
storeFile = rootProject.file("debug.keystore")
storeFile = File(System.getProperty("user.home"), ".android/debug.keystore")
storePassword = "android"
keyAlias = "androiddebugkey"
keyPassword = "android"
Expand Down
Binary file removed Jetsnack/debug.keystore
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions Owl/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ android {
}

signingConfigs {
// We use a bundled debug keystore, to allow debug builds from CI to be upgradable
// Important: change the keystore for a production deployment
named("debug") {
storeFile = rootProject.file("debug.keystore")
storeFile = File(System.getProperty("user.home"), ".android/debug.keystore")
storePassword = "android"
keyAlias = "androiddebugkey"
keyPassword = "android"
Expand Down
Binary file removed Owl/debug.keystore
View file
Open in desktop
Binary file not shown.
4 changes: 2 additions & 2 deletions Reply/app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,9 +34,9 @@ android {
}

signingConfigs {
// We use a bundled debug keystore, to allow debug builds from CI to be upgradable
// Important: change the keystore for a production deployment
named("debug") {
storeFile = rootProject.file("debug.keystore")
storeFile = File(System.getProperty("user.home"), ".android/debug.keystore")
storePassword = "android"
keyAlias = "androiddebugkey"
keyPassword = "android"
Expand Down
Binary file removed Reply/debug.keystore
View file
Open in desktop
Binary file not shown.