Skip to content

[Jetchat] Fix RecordButton sending cancellation callback continuously #1190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 3, 2023
Merged

[Jetchat] Fix RecordButton sending cancellation callback continuously #1190

merged 1 commit into from
Oct 3, 2023

Conversation

@bentrengrove
Copy link
Member

@bentrengrove bentrengrove commented Oct 2, 2023

  • Fixes RecordButton sending onCancelled continuously until the finger is raised, then still sending onFinished
  • Refactors to not need composed {}

@bentrengrove bentrengrove requested a review from a team as a code owner October 2, 2023 03:45
@bentrengrove bentrengrove changed the title [Jetchat[ Fix RecordButton sending cancellation callback continuously [Jetchat] Fix RecordButton sending cancellation callback continuously Oct 2, 2023
@bentrengrove bentrengrove merged commit 00fe215 into main Oct 3, 2023
@bentrengrove bentrengrove deleted the ben/record_button branch October 3, 2023 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JolandaVerhoef JolandaVerhoef JolandaVerhoef approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bentrengrove @JolandaVerhoef