-
Notifications
You must be signed in to change notification settings - Fork 209
Docs: Update Remote Config instructions #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The setup instructions in the README are updated to reflect the process of uploading a JSON file for Firebase Remote Config. Transformed the file remote_config_defaults.xml to json format `remote_config_defaults.json`. This new file is added to establish default settings for the application's remote config feature flags and prompts.
Summary of ChangesHello @AndreSand, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the Firebase Remote Config setup by transitioning from an XML-based configuration to a more modern and manageable JSON format. It updates the documentation to guide users through the new JSON upload process and introduces a comprehensive default JSON file that defines various feature flags and AI-related prompt templates for the application. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the Firebase Remote Config setup instructions by introducing a JSON template file. This is a great change that simplifies the setup process. My review includes a few suggestions for the README.md
file to improve the clarity and accuracy of the new instructions, ensuring developers can follow them without confusion. Specifically, I've pointed out a contradictory statement and some outdated UI references in the Firebase Console steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
The setup instructions in the README are updated to reflect the process of uploading a JSON file for Firebase Remote Config.
Transformed the file remote_config_defaults.xml to json format
remote_config_defaults.json
. This new file is added to establish default settings for the application's remote config feature flags and prompts.Fyi: Wrote a medium blog post about the setup with images https://andresand.medium.com/exploring-googles-demo-app-androidify-439149b8750c