Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Update gradle and external dependencies #429

Merged
merged 3 commits into from
Oct 11, 2018
Merged

Update gradle and external dependencies #429

merged 3 commits into from
Oct 11, 2018

Conversation

msfjarvis
Copy link
Member

  • Switch away from deprecated compile directive
  • Remove explicit buildToolsVersion, is defined by the gradle plugin now
  • Fix build in SelectFolderActivity

Signed-off-by: Harsh Shandilya [email protected]

- Switch away from deprecated compile directive
- Remove explicit buildToolsVersion, is defined by the gradle plugin now
- Fix build in SelectFolderActivity

Signed-off-by: Harsh Shandilya <[email protected]>
@msfjarvis msfjarvis mentioned this pull request Oct 2, 2018
@zidhuss
Copy link
Contributor

zidhuss commented Oct 2, 2018

Thanks for the pull request.

Did you get this to work without breaking Android Studio's instant run?

@msfjarvis
Copy link
Member Author

I don't use Instant Run but I don't see how anything here would break it.

@zeapo
Copy link
Contributor

zeapo commented Oct 2, 2018

That should work.
@MSF-Jarvis any reason for gradle 4.6 vs 4.8 (or 4.10.2?)

@zidhuss
Copy link
Contributor

zidhuss commented Oct 2, 2018

I get this when trying to run with Instant Run enabled:

SHA-256 digest error for org/eclipse/jgit/transport/CredentialsProvider.class

@msfjarvis
Copy link
Member Author

@zeapo I wasn't sure about the policy on alpha plugins with the project, I'll go bump everything to the latest available in a few.

@zidhuss no idea about that, will try to see if there's something I can do on my end. Did you try invalidating caches? Instant run is notoriously annoying about build caches :(

@zeapo
Copy link
Contributor

zeapo commented Oct 2, 2018

@MSF-Jarvis I don't think (maybe I'm wrong) that we need the alpha on the plugin to be able to use a 4.8 or 4.10 (https://developer.android.com/studio/releases/gradle-plugin#3-2-0)

@msfjarvis
Copy link
Member Author

Ah, true. Will downgrade the plugin back.

Signed-off-by: Harsh Shandilya <[email protected]>
@zidhuss zidhuss merged commit 8ff0039 into android-password-store:master Oct 11, 2018
@msfjarvis msfjarvis deleted the msf/upgrade_deps branch October 11, 2018 16:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants