rebase transport: preserve #79250 Windows warning fix - #99
Merged
andrexibiza merged 1 commit intoAug 21, 2026
Conversation
gitFor() opts into simple-git's unsafe.allowUnsafeCustomBinary when the resolved git binary path contains a space (the default Windows install, C:\Program Files\Git\cmd\git.exe). That opt-in trades simple-git's throw for a console.warn emitted on EVERY client construction, and gitFor() is not memoized — the coding rail rebuilds a client on each status poll, so the desktop log filled with hundreds of identical lines that buried real errors. Suppress only that known warning, only for the duration of the construction call, and restore console.warn in a finally so unrelated warnings still surface. Fixes NousResearch#79245
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary proof-preserving rebase transport for upstream NousResearch#79250. Replays @hernanda-git's original commit onto exact upstream
mainatac8dff4fbcf47a392a3cddcbec068aa05930ab47; not a public delivery artifact.