TEMP: merge 78196 onto current main - #33
Closed
andrexibiza wants to merge 3 commits into
Closed
andrexibiza wants to merge 3 commits into
andrexibiza wants to merge 3 commits into
Conversation
Prevents a stalled gateway speech-to-text call from holding a messaging chat indefinitely. Gateway voice transcription runs synchronous provider work through asyncio.to_thread(); provider HTTP/process timeouts do not cover hangs in setup, local fallback, filesystem access, or cleanup, so one stuck call can block the chat lock and every later message in that conversation. Adds a configurable gateway-level deadline (stt_timeout_seconds, default 45s; stt.gateway_timeout_seconds in config.yaml) around the complete configured-provider + local-fallback sequence. On timeout, Hermes logs the failure, keeps the existing audio-path marker, and continues fail-open so the agent can respond instead of leaving the chat wedged. Salvaged from NousResearch#74051, authored by @mglavinic86. Signed-off-by: andrexibiza <84248988+andrexibiza@users.noreply.github.com>
Salvaged residual gaps from NousResearch#65745 (authored by @dhansxd) that are not already covered on main: - Recover allowed media producers from explicit tool-result tool_name / name when the paired assistant tool_calls row is absent. Persisted or reconstructed tool results that lost that row previously fell out of the automatic-delivery allowlist, so their TTS/audio MEDIA tags were silently dropped instead of delivered. - Log unsuccessful auto voice-reply SendResult values instead of silently ignoring them, so delivery failures are diagnosable. The other NousResearch#65745 changes (drop silent transcripts before invoking the agent, transcribe voice follow-ups before busy-session handling) are already covered on main by NousResearch#41603's empty-transcript sentinel and the pending-STT cache, so they are intentionally not re-applied. Co-Authored-By: Dani Ubaidillah Husain <daniubaidillahhusain@gmail.com> Signed-off-by: andrexibiza <84248988+andrexibiza@users.noreply.github.com>
…ribution Maps the author emails of the two salvaged gateway voice commits (from NousResearch#74051 @mglavinic86 and NousResearch#65745 @dhansxd) so the check-attribution CI gate can resolve them to their GitHub identities. Signed-off-by: andrexibiza <84248988+andrexibiza@users.noreply.github.com>
Owner
Author
|
Closing this fork-local duplicate because its exact head commit is already under upstream review in NousResearch#78196. The branch is intentionally retained while that upstream PR remains open; this closes only the redundant fork review surface. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary internal merge probe for rebuilding NousResearch#78196 onto current main. Not an upstream publication.