stream: fix array out-of-bounds in stream_get_timing_info_callback #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This issue was found by enabling ubsan. For me it consistently triggered after about 28 seconds running a simple example that plays a sine wave via the mainloop api. I added a log and confirmed that before the ubsan is triggered the index variable j is indeed 32 which is out-of-bounds. This commit was cherry-picked from upstream: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/commit/1fbc6b0e0e796ea1e78825fce4ca815475d30294 Co-authored-by: Arun Raghavan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #5
I fixed and merged an array out-of-bounds access upstream here: https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/850
I've cherry-picked the same change in this PR.