Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak #10

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Fix memory leak #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@
*/
let callbacks = [];

const channel = new MessageChannel();
let channel = new MessageChannel();

let postMessage = (function() {
this.postMessage(undefined);
}).bind(channel.port2);

// Flush the callback queue when a message is posted to the message channel
channel.port1.onmessage = () => {
Expand All @@ -22,9 +26,8 @@ channel.port1.onmessage = () => {
}
};

function postMessage() {
channel.port2.postMessage(undefined);
}
// If the onmessage handler closes over the MessageChannel, the MessageChannel never gets GC'd:
channel = null;

/**
* Invoke the given callback after the browser renders the next frame
Expand Down