Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing bug in addErrorMessages method #23

Merged

Conversation

algm
Copy link
Contributor

@algm algm commented Sep 9, 2015

I fixed a minor bug in the addErrorsMessages method in which the type variable was undefined.

@andrewhathaway
Copy link
Owner

Sorry for being picky, but this one I think should be done a little differently in the sense that the var/let keyword should be place inside of the loops "parameters", as such. IE:

for (let prop in obj) { ... }

Just to keep it clean, and how its usually approached. Good spot!

@algm
Copy link
Contributor Author

algm commented Sep 10, 2015

I moved the let definition as you suggested, thanks for the feedback!

andrewhathaway added a commit that referenced this pull request Sep 11, 2015
@andrewhathaway andrewhathaway merged commit 25ad48e into andrewhathaway:master Sep 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants