feat: Add per-model filtering to Merbench page #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change introduces a new filter to the Merbench page, allowing users to select individual models in addition to the existing provider-level filter. The implementation includes: - A new "Model" checkbox group in the `CombinedFilters.astro` component. - Updates to `merbench.astro` to pass the model list to the filter component. - Modifications to `merbench-filters.ts` to handle the new filter's state and events. - An update to the `getFilteredData` function in `merbench.ts` to apply the model selection to the dataset.
|
✅ Preview deployment ready! 📋 PR #40 has been deployed to: https://andrewginns.github.io/ Built from commit: 36e6242 This preview will be updated automatically when you push new commits to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change introduces a new filter to the Merbench page, allowing users to select individual models in addition to the existing provider-level filter.
The implementation includes:
CombinedFilters.astrocomponent.merbench.astroto pass the model list to the filter component.merbench-filters.tsto handle the new filter's state and events.getFilteredDatafunction inmerbench.tsto apply the model selection to the dataset.