Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for command on new line after prompt and made it fancy #33

Merged

Conversation

santicardona
Copy link
Contributor

As the title says, added a couple of lines and changed config files and documentation to add the possibility to have a line break between prompt and command line.

This targets the issue #29 of this Repo and feature request #226 in the synth-shell Repo. The new look can be directly seen in the documentation but here a screen-capture anyways:

next_line_command

Hope the format is of your liking. Let me know if I can do anything else so that the request gets accepted.

@andresgongora
Copy link
Owner

andresgongora commented Aug 8, 2023

Hi @santicardona . Thanks so much for you contribution, please update your PR and add yourself to the contributors file: https://github.com/andresgongora/synth-shell-prompt/blob/master/AUTHORS.md

I wrote this script several years ago. I remember I put it support for new lines using the parameter enable_vertical_padding=true # Add extra new line over prompt, which is (I recon) way less useful thank yours. However I'm not 100% sure how the old one used to work since I never used it myself. Would you mind checking and removing the old vertical padding if it does nothing that yours doesn't do better?

Maybe you also want to edit the README.md file to add your screenshot and a brief explanation somewhere

@santicardona
Copy link
Contributor Author

santicardona commented Aug 8, 2023

Hi @andresgongora . The option enable_vertical_padding is there to add a padding before the prompt and the way I see it, it is still useful to have enough space between the command result and a new prompt. So I would not remove it.

Also, I already had updated the README and added the screenshot. Thanks for your quick reply.

@andresgongora
Copy link
Owner

Excellent then. Let's merge!

@andresgongora andresgongora merged commit 91ced85 into andresgongora:master Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants