feat: adopt shared LocalizedText from design-blazor - #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
AndreGoepel.Design.Blazor1.4.2 → 1.6.0 (both root andsamples/Directory.Packages.props, which must stay in lockstep — restore fails with NU1605 otherwise). DeletesIdentityTextExtensions.cs;IdentityLocalizedComponentBaseis now a one-line: LocalizedComponentBase<IdentityStrings>closed-generic subclass of the shared design-blazor base.IdentityStringsand the resx files stay untouched.All ~38 Razor pages needed zero changes — they only ever said
@inherits IdentityLocalizedComponentBase, a name that keeps resolving to the same local type.Verification
dotnet csharpier format .cleandotnet build— 0 warnings, 0 errorsdotnet test— 191 + 130 + 92 = 413 passing, including all 130 bUnit tests that render every identity page through this base classdotnet list package --vulnerable --include-transitive— cleanCloses #155