feat: adopt AndreGoepel.Testing.E2E - #159
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the local
Infrastructure/fork (E2EAppFixture,E2ETestBase,PageExtensionscore,TestData,Totp,VirtualAuthenticator) with the newly publishedAndreGoepel.Testing.E2E1.0.0 — this repo's own copy was one of the three source-of-truth forks that package was extracted from, and is where the mandatory trace-capture-on-failure feature originated.Design
E2EAppFixtureis a parameterless subclass of the package's fixture, configured viaE2EAppFixtureOptions(WebResourceName="web",ProvisionAdminButtonText="Create administrator").E2E=trueit captures mail itself rather than using MailHog.CapturedEmailClientnow implements the package'sIEmailLinkSourceand is wired in viaMailSourceFactory, exactly the extension seam that interface exists for.PageExtensions.FilterUsersGridAsyncas a local extension on top of the package's core.global using E2EAppFixture = ...alias resolves the name collision between this repo's fixture and the package's ownE2EAppFixturebase type.E2ETestBase<TFixture>carries this repo's original trace-capture-on-failure logic verbatim (samePLAYWRIGHT_TRACE_DIRenv var, same unconditional-on-failure behavior) — nothing lost in the move.Net: -496/+61 lines.
Verification
dotnet csharpier format .cleandotnet build— 0 warnings, 0 errorsdotnet test(non-Docker) — 321/321 passingdotnet list package --vulnerable --include-transitive— cleanCloses #153