refactor: rename Aspire samples to AndreGoepel.Marten.Identity naming scheme - #149
Merged
Merged
Conversation
… scheme The sample projects (MartenIdentity.Aspire.AppHost/.ServiceDefaults/.Web) didn't follow the repo's package naming convention. Renamed to: - AndreGoepel.Marten.Identity.AppHost - AndreGoepel.Marten.Identity.ServiceDefaults - AndreGoepel.Marten.Identity.Sample (was .Web) Updated all namespaces, project references, the .slnx, generated Projects.* type names, the E2E test project/fixture, and docs. The new Sample namespace still starts with "AndreGoepel.Marten...", which shadows the Marten package's top-level namespace for unqualified lookups in Razor-generated code (nested "using Marten;" inside the namespace block). Setup.razor now qualifies IQuerySession as global::Marten.IQuerySession to work around this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.NET Aspiresample projects undersamples/to follow the repo's package naming convention:MartenIdentity.Aspire.AppHost→AndreGoepel.Marten.Identity.AppHostMartenIdentity.Aspire.ServiceDefaults→AndreGoepel.Marten.Identity.ServiceDefaultsMartenIdentity.Aspire.Web→AndreGoepel.Marten.Identity.Sample.slnx, the generated AspireProjects.*type names, the E2E test project/fixture, and docs (README.md,CLAUDE.md,samples/README.md, E2E test README) to match.Notes for reviewers
AndreGoepel.Marten.Identity.Samplenamespace still starts withAndreGoepel.Marten..., same as the core library. This shadows theMartenNuGet package's top-level namespace for unqualified lookups inside Razor-generated code, because Razor emitsusing Marten;nested inside the file's own namespace block, and C#'s namespace lookup then resolvesMartentoAndreGoepel.Marten(this project's own namespace) instead of the package.Setup.razornow qualifies the injected session asglobal::Marten.IQuerySessionto work around this — it's the only place in the sample that referenced aMartentype unqualified.dotnet build),dotnet csharpier format .applied, and the unit + Blazor test suites pass (191 + 130 tests).Test plan
dotnet build AndreGoepel.Marten.Identity.slnxsucceedsdotnet test tests/AndreGoepel.Marten.Identity.Testspassesdotnet test tests/AndreGoepel.Marten.Identity.Blazor.Testspasses