refactor: convention cleanup, unify AddToRole/RemoveFromRole error contract

src/AndreGoepel.Marten.Identity.Blazor/Components/Account/IdentityComponentsEndpointRouteBuilderExtensions.cs

@@ -15,7 +15,6 @@ namespace AndreGoepel.Marten.Identity.Blazor.Components.Account;
 
 public static class IdentityComponentsEndpointRouteBuilderExtensions
 {
-    // These endpoints are required by the Identity Razor components defined in the /Components/Account/Pages directory of this project.
     public static IEndpointConventionBuilder MapAdditionalIdentityEndpoints(
         this IEndpointRouteBuilder endpoints
     )

src/AndreGoepel.Marten.Identity.Blazor/Components/Account/IdentityRevalidatingAuthenticationStateProvider.cs

@@ -9,8 +9,6 @@
 
 namespace AndreGoepel.Marten.Identity.Blazor.Components.Account;
 
-// This is a server-side AuthenticationStateProvider that revalidates the security stamp for the connected user
-// every 30 minutes an interactive circuit is connected.
 internal sealed class IdentityRevalidatingAuthenticationStateProvider(
     ILoggerFactory loggerFactory,
     IServiceScopeFactory scopeFactory,

src/AndreGoepel.Marten.Identity.Blazor/Components/Account/Pages/AccessDenied.razor

@@ -1,8 +1,11 @@
 @page "/Account/AccessDenied"
 @attribute [AllowAnonymous]
+@inherits IdentityLocalizedComponentBase
 
 @inject NavigationManager NavigationManager
 
+<AppPageTitle Title="@T("AccessDenied.PageTitle")" />
+
 @code {
     protected override void OnInitialized()
     {

src/AndreGoepel.Marten.Identity.Blazor/Components/Account/Pages/Manage/ChangePassword.razor

@@ -85,7 +85,7 @@
             string.IsNullOrWhiteSpace(model.NewPassword) ||
             string.IsNullOrWhiteSpace(model.ConfirmPassword))
         {
-            return; // Validatoren sollten das bereits abfangen
+            return; // Validators should already catch this
         }
 
         if (model.NewPassword != model.ConfirmPassword)
@@ -95,7 +95,6 @@
         }
 
         _isProcessing = true;
-        StateHasChanged();
 
         try
         {
@@ -115,7 +114,6 @@
                 );
 
                 Model = new();
-                StateHasChanged();
             }
             else
             {
@@ -139,14 +137,10 @@
         finally
         {
             _isProcessing = false;
-            StateHasChanged();
         }
     }
 
-    // Validation lives in the markup as Radzen validator components. RadzenTemplateForm
-    // (wrapped by CardForm) does not evaluate DataAnnotations and no DataAnnotationsValidator
-    // is present, so attributes here would never run — they were removed rather than
-    // translated into a second, silently-dead set of messages (#114).
+    // Validation lives in the markup as Radzen validators — RadzenTemplateForm/CardForm don't run DataAnnotations (#114).
     private sealed class ChangePasswordModel
     {
         [DataType(DataType.Password)]

src/AndreGoepel.Marten.Identity.Blazor/Components/Account/Pages/Manage/DeletePersonalData.razor

@@ -20,7 +20,6 @@
         <RadzenCard>
             <RadzenStack Orientation="Orientation.Vertical" Gap="2rem" AlignItems="AlignItems.Stretch">
 
-            <!-- Starke Warnung -->
             <RadzenAlert AlertStyle="AlertStyle.Danger"
                          AllowClose="false"
                          Icon="warning"
@@ -96,7 +95,6 @@
             return;
         }
 
-        // Zweifache Absicherung über Dialog
         var confirm = await Confirm.ConfirmAsync(
             T("DeletePersonalData.ConfirmMessage"),
             T("DeletePersonalData.ConfirmTitle"),
@@ -114,7 +112,6 @@
 
         try
         {
-            // Passwort prüfen
             if (!await UserManager.CheckPasswordAsync(_currentUser, model.Password))
             {
                 NotificationService.Notify(NotificationSeverity.Error, T("DeletePersonalData.ErrorTitle"), T("DeletePersonalData.WrongPasswordDetail"));
@@ -149,14 +146,10 @@
         finally
         {
             _isDeleting = false;
-            StateHasChanged();
         }
     }
 
-    // Validation lives in the markup as Radzen validator components. RadzenTemplateForm
-    // (wrapped by CardForm) does not evaluate DataAnnotations and no DataAnnotationsValidator
-    // is present, so attributes here would never run — they were removed rather than
-    // translated into a second, silently-dead set of messages (#114).
+    // Validation lives in the markup as Radzen validators — RadzenTemplateForm/CardForm don't run DataAnnotations (#114).
     private sealed class InputModel
     {
         [DataType(DataType.Password)]

src/AndreGoepel.Marten.Identity.Blazor/Components/Account/Pages/Manage/Disable2fa.razor

@@ -65,7 +65,6 @@
     private async Task OnSubmitAsync()
     {
         _isProcessing = true;
-        StateHasChanged();
 
         try
         {
@@ -79,7 +78,17 @@
 
             if (!result.Succeeded)
             {
-                throw new InvalidOperationException("Failed to disable 2FA: " + string.Join(", ", result.Errors.Select(e => e.Description)));
+                Logger.LogError(
+                    "Failed to disable 2FA for user {UserId}: {Errors}",
+                    _user.Id,
+                    string.Join(", ", result.Errors.Select(e => e.Description))
+                );
+                NotificationService.Notify(
+                    NotificationSeverity.Error,
+                    summary: T("Disable2fa.ErrorTitle"),
+                    detail: T("Disable2fa.DisableFailedDetail")
+                );
+                return;
             }
 
             var userId = await UserManager.GetUserIdAsync(_user);
@@ -91,7 +100,7 @@
         }
         catch (Exception ex)
         {
-            Logger.LogError(ex, "Failed to disable 2FA for user {UserId}", _user?.Id);
+            Logger.LogError(ex, "Unexpected error while disabling 2FA for user {UserId}", _user?.Id);
             NotificationService.Notify(
                 NotificationSeverity.Error,
                 summary: T("Disable2fa.ErrorTitle"),
@@ -101,7 +110,6 @@
         finally
         {
             _isProcessing = false;
-            StateHasChanged();
         }
     }
 

src/AndreGoepel.Marten.Identity.Blazor/Components/Account/Pages/Manage/Email.razor

@@ -105,7 +105,6 @@
         }
 
         _isChangingEmail = true;
-        StateHasChanged();
 
         try
         {
@@ -132,9 +131,6 @@
                 T("Email.SuccessTitle"),
                 T("Email.ConfirmationSentDetail")
             );
-
-            // Optional: zurück zur Profile-Seite
-            // NavigationManager.NavigateTo("/Account/Manage/Profile");
         }
         catch (Exception)
         {
@@ -147,7 +143,6 @@
         finally
         {
             _isChangingEmail = false;
-            StateHasChanged();
         }
     }
 
@@ -157,7 +152,6 @@
             return;
 
         _isSendingVerification = true;
-        StateHasChanged();
 
         try
         {
@@ -195,14 +189,10 @@
         finally
         {
             _isSendingVerification = false;
-            StateHasChanged();
         }
     }
 
-    // Validation lives in the markup as Radzen validator components. RadzenTemplateForm
-    // (wrapped by CardForm) does not evaluate DataAnnotations and no DataAnnotationsValidator
-    // is present, so attributes here would never run — they were removed rather than
-    // translated into a second, silently-dead set of messages (#114).
+    // Validation lives in the markup as Radzen validators — RadzenTemplateForm/CardForm don't run DataAnnotations (#114).
     private sealed class ChangeEmailModel
     {
         public string? NewEmail { get; set; }

src/AndreGoepel.Marten.Identity.Blazor/Components/Account/Pages/Manage/EnableAuthenticator.razor

@@ -121,7 +121,6 @@ else
             return;
         }
 
-        // Strip spaces and hyphens
         var verificationCode = model.Code?.Replace(" ", string.Empty).Replace("-", string.Empty) ?? "";
 
         var is2FaTokenValid = await UserManager.VerifyTwoFactorTokenAsync(
@@ -151,7 +150,6 @@ else
 
     private async ValueTask LoadSharedKeyAndQrCodeUriAsync(User user)
     {
-        // Load the authenticator key & QR code URI to display on the form
         var unformattedKey = await UserManager.GetAuthenticatorKeyAsync(user);
         if (string.IsNullOrEmpty(unformattedKey))
         {

src/AndreGoepel.Marten.Identity.Blazor/Components/Account/Pages/Manage/Passkeys.razor

@@ -105,7 +105,6 @@
     protected override async Task OnInitializedAsync()
     {
         _isLoading = true;
-        StateHasChanged();
 
         try
         {
@@ -128,7 +127,6 @@
         finally
         {
             _isLoading = false;
-            StateHasChanged();
         }
     }
 

src/AndreGoepel.Marten.Identity.Blazor/Components/Account/Pages/Manage/PersonalData.razor

@@ -19,12 +19,10 @@
         <RadzenCard>
             <RadzenStack Orientation="Orientation.Vertical" Gap="2rem" AlignItems="AlignItems.Stretch">
 
-            <!-- Erklärungstext -->
             <RadzenText TextStyle="TextStyle.Body1">
                 @T("PersonalData.IntroText")
             </RadzenText>
 
-            <!-- Warnhinweis -->
             <RadzenAlert AlertStyle="AlertStyle.Danger"
                          AllowClose="false"
                          Icon="warning">
@@ -35,7 +33,6 @@
             </RadzenAlert>
 
             <div class="ag-card-actions ag-start">
-                <!-- Download (POST form) -->
                 <form action="/Account/Manage/DownloadPersonalData" method="post">
                     <AntiforgeryToken />
                     <RadzenButton ButtonType="ButtonType.Submit"

src/AndreGoepel.Marten.Identity.Blazor/Components/Account/Pages/Manage/Profile.razor

@@ -70,7 +70,6 @@
         }
 
         _isSaving = true;
-        StateHasChanged();
 
         try
         {
@@ -119,14 +118,10 @@
         finally
         {
             _isSaving = false;
-            StateHasChanged();
         }
     }
 
-    // Validation lives in the markup as Radzen validator components. RadzenTemplateForm
-    // (wrapped by CardForm) does not evaluate DataAnnotations and no DataAnnotationsValidator
-    // is present, so attributes here would never run — they were removed rather than
-    // translated into a second, silently-dead set of messages (#114).
+    // Validation lives in the markup as Radzen validators — RadzenTemplateForm/CardForm don't run DataAnnotations (#114).
     private sealed class ProfileModel
     {
         // UserName is rendered read-only, so it cannot be emptied from the UI.

src/AndreGoepel.Marten.Identity.Blazor/Components/Account/Pages/Manage/RenamePasskey.razor

@@ -125,7 +125,6 @@
         }
 
         _isSaving = true;
-        StateHasChanged();
 
         try
         {
@@ -168,14 +167,10 @@
         finally
         {
             _isSaving = false;
-            StateHasChanged();
         }
     }
 
-    // Validation lives in the markup as Radzen validator components. RadzenTemplateForm
-    // (wrapped by CardForm) does not evaluate DataAnnotations and no DataAnnotationsValidator
-    // is present, so attributes here would never run — they were removed rather than
-    // translated into a second, silently-dead set of messages (#114).
+    // Validation lives in the markup as Radzen validators — RadzenTemplateForm/CardForm don't run DataAnnotations (#114).
     private sealed class RenamePasskeyModel
     {
         public string Name { get; set; } = "";

src/AndreGoepel.Marten.Identity.Blazor/Components/Account/Pages/Manage/ResetAuthenticator.razor

@@ -17,7 +17,6 @@
         <RadzenCard>
             <RadzenStack Orientation="Orientation.Vertical" Gap="2rem" AlignItems="AlignItems.Stretch">
 
-            <!-- Warning (prominent, danger style) -->
             <RadzenAlert AlertStyle="AlertStyle.Danger" Icon="warning" AllowClose="false">
                 <div class="font-medium">
                     @T("ResetAuthenticator.AlertLine1")
@@ -28,7 +27,6 @@
                 </div>
             </RadzenAlert>
 
-            <!-- Action area -->
             <RadzenStack Gap="1.5rem" AlignItems="AlignItems.Center">
 
                 <form method="post" action="/Account/Manage/ResetAuthenticator/ConfirmReset">

src/AndreGoepel.Marten.Identity.Blazor/Components/Account/Pages/Register.razor

@@ -87,10 +87,6 @@
 
         if (!result.Succeeded)
         {
-            // Pre-existing bug fixed in passing: this joined the IdentityError objects
-            // themselves, not their Description — IdentityError doesn't override ToString(),
-            // so the notification showed the bare type name instead of the actual reason.
-            // No test covered the text, only that a notification fired, so it went unnoticed.
             var reasons = string.Join(' ', result.Errors.Select(e => e.Description));
             NotificationService.Notify(
                 NotificationSeverity.Error,

src/AndreGoepel.Marten.Identity.Blazor/Components/Account/PasskeyInputModel.cs

@@ -1,6 +1,6 @@
 namespace AndreGoepel.Marten.Identity.Blazor.Components.Account;
 
-public class PasskeyInputModel
+public sealed class PasskeyInputModel
 {
     public string? CredentialJson { get; set; }
     public string? Error { get; set; }

src/AndreGoepel.Marten.Identity.Blazor/Components/Account/Shared/PasskeySubmit.razor

@@ -34,7 +34,6 @@
         if (_module is null) return;
 
         _isBusy = true;
-        StateHasChanged();
 
         try
         {
@@ -56,7 +55,6 @@
         finally
         {
             _isBusy = false;
-            StateHasChanged();
         }
     }
 

src/AndreGoepel.Marten.Identity.Blazor/Components/Administration/Dialogs/RoleUserDialog.razor

@@ -2,6 +2,7 @@
 @inject DialogService DialogService
 @inject ConfirmService Confirm
 @inject UserManager<User> UserManager
+@inject UserStore<User> UserStore
 @inject RoleManager<Role> RoleManager
 
 <RadzenStack Gap="1rem" Orientation="Orientation.Vertical" JustifyContent="JustifyContent.SpaceBetween">
@@ -56,7 +57,7 @@
                 return;
             }
 
-            var deleteResult = await UserManager.RemoveFromRoleAsync(user, _role.Name);
+            var deleteResult = await UserStore.RemoveFromRoleAsync(user, _role.Name, CancellationToken.None);
             if (deleteResult.Succeeded)
             {
                 _users = _users.Where(u => u.Id != user.Id).ToList();